Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 14:52:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1902171 - Remove PWMGR_NUM_FORM_HAS_POSSIBLE_USERNAME_EVENT_PER_DOC probe. r=dimi,credential-management-reviewers

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D214838
This commit is contained in:
tessa 2024-07-03 20:08:06 +00:00
parent 8f68d07560
commit 99a995d8fa
3 changed files with 1 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
toolkit/components/passwordmgr/LoginManagerChild.sys.mjs
View File

@ -1812,14 +1812,11 @@ export class LoginManagerChild extends JSWindowActorChild {
// document receives two `DOMFormHasPossibleEvent`, we add one counter to both
// bucket 1 & 2.
let docState = this.stateForDocument(document);
Services.telemetry
.getHistogramById("PWMGR_NUM_FORM_HAS_POSSIBLE_USERNAME_EVENT_PER_DOC")
.add(++docState.numFormHasPossibleUsernameEvent);
// Infer whether a form is a username-only form is expensive, so we restrict the
// number of form looked up per document.
if (
docState.numFormHasPossibleUsernameEvent >
++docState.numFormHasPossibleUsernameEvent >
lazy.LoginHelper.usernameOnlyFormLookupThreshold
) {
return;

30
toolkit/components/passwordmgr/test/browser/browser_username_only_form_telemetry.js
View File

@ -95,11 +95,6 @@ add_task(async function test_oneUsernameOnlyForm() {
1,
numUsernameOnlyForms
);
await checkChildHistogram(
"PWMGR_NUM_FORM_HAS_POSSIBLE_USERNAME_EVENT_PER_DOC",
numUsernameOnlyForms,
1
);
BrowserTestUtils.removeTab(tab);
Services.telemetry.getSnapshotForHistograms("main", true /* clear */);
@ -116,11 +111,6 @@ add_task(async function test_multipleUsernameOnlyForms() {
1,
numUsernameOnlyForms
);
await checkChildHistogram(
"PWMGR_NUM_FORM_HAS_POSSIBLE_USERNAME_EVENT_PER_DOC",
5,
1
);
BrowserTestUtils.removeTab(tab);
Services.telemetry.getSnapshotForHistograms("main", true /* clear */);
@ -138,11 +128,6 @@ add_task(async function test_multipleDocument() {
1,
numUsernameOnlyForms1
);
await checkChildHistogram(
"PWMGR_NUM_FORM_HAS_POSSIBLE_USERNAME_EVENT_PER_DOC",
numUsernameOnlyForms1 + numBasicForms1,
1
);
// The second document
let numUsernameOnlyForms2 = 15;
@ -158,16 +143,6 @@ add_task(async function test_multipleDocument() {
// the result is stacked, so the new document add a counter to all
// buckets under "numUsernameOnlyForms2 + numBasicForms2"
await checkChildHistogram(
"PWMGR_NUM_FORM_HAS_POSSIBLE_USERNAME_EVENT_PER_DOC",
numUsernameOnlyForms1 + numBasicForms1,
2
);
await checkChildHistogram(
"PWMGR_NUM_FORM_HAS_POSSIBLE_USERNAME_EVENT_PER_DOC",
numUsernameOnlyForms2 + numBasicForms2,
1
);
BrowserTestUtils.removeTab(tab1);
BrowserTestUtils.removeTab(tab2);
@ -185,11 +160,6 @@ add_task(async function test_tooManyUsernameOnlyForms() {
1,
numUsernameOnlyForms
);
await checkChildHistogram(
"PWMGR_NUM_FORM_HAS_POSSIBLE_USERNAME_EVENT_PER_DOC",
21,
numUsernameOnlyForms + numBasicForms - 20 // maximum is 20
);
BrowserTestUtils.removeTab(tab);
Services.telemetry.getSnapshotForHistograms("main", true /* clear */);

12
toolkit/components/telemetry/Histograms.json
View File

@ -13999,18 +13999,6 @@
"releaseChannelCollection": "opt-out",
"record_into_store": ["main"]
},
"PWMGR_NUM_FORM_HAS_POSSIBLE_USERNAME_EVENT_PER_DOC": {
"record_in_processes": ["content"],
"products": ["firefox", "fennec"],
"expires_in_version": "130",
"kind": "linear",
"high": 21,
"n_buckets": 20,
"bug_numbers": [1708455, 1791929, 1822724],
"description": "The number of documents that receive >= bucket number 'DOMFormHasPossibleUsernameEvent' event",
"alert_emails": ["passwords-dev@mozilla.org"],
"releaseChannelCollection": "opt-out"
},
"PWMGR_NUM_SAVED_PASSWORDS": {
"record_in_processes": ["main"],
"products": ["firefox", "fennec", "thunderbird"],