Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 08:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1171723 - Fix clear button in variable view. r=bgrins

Browse Source
This commit is contained in:
Alexandre Poirot 2015-07-10 00:21:00 -07:00
parent d6c9811e6f
commit 9a6d3dd5ef
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
browser/devtools/debugger/test/browser_dbg_variables-view-filter-01.js
View File

@ -98,6 +98,7 @@ function testVariablesAndPropertiesFiltering() {
function firstFilter() { function firstFilter() {
let expanded = once(gVariables, "fetched"); let expanded = once(gVariables, "fetched");
typeText(gSearchBox, "constructor"); typeText(gSearchBox, "constructor");
gSearchBox.doCommand();
return expanded.then(testFiltered); return expanded.then(testFiltered);
} }

2
browser/devtools/debugger/test/browser_dbg_variables-view-filter-02.js
View File

@ -105,6 +105,7 @@ function testVariablesAndPropertiesFiltering() {
function firstFilter() { function firstFilter() {
let expanded = once(gVariables, "fetched"); let expanded = once(gVariables, "fetched");
typeText(gSearchBox, "\"Function\""); typeText(gSearchBox, "\"Function\"");
gSearchBox.doCommand();
return expanded.then(testFiltered); return expanded.then(testFiltered);
} }
@ -139,6 +140,7 @@ function testVariablesAndPropertiesFiltering() {
backspaceText(gSearchBox, 10); backspaceText(gSearchBox, 10);
let expanded = once(gVariables, "fetched"); let expanded = once(gVariables, "fetched");
typeText(gSearchBox, "\"Function\""); typeText(gSearchBox, "\"Function\"");
gSearchBox.doCommand();
expanded.then(testFiltered); expanded.then(testFiltered);
} }

4
browser/devtools/shared/widgets/VariablesView.jsm
View File

@ -453,7 +453,7 @@ VariablesView.prototype = {
searchbox.setAttribute("placeholder", this._searchboxPlaceholder); searchbox.setAttribute("placeholder", this._searchboxPlaceholder);
searchbox.setAttribute("type", "search"); searchbox.setAttribute("type", "search");
searchbox.setAttribute("flex", "1"); searchbox.setAttribute("flex", "1");
searchbox.addEventListener("input", this._onSearchboxInput, false); searchbox.addEventListener("command", this._onSearchboxInput, false);
searchbox.addEventListener("keypress", this._onSearchboxKeyPress, false); searchbox.addEventListener("keypress", this._onSearchboxKeyPress, false);
container.appendChild(searchbox); container.appendChild(searchbox);
@ -470,7 +470,7 @@ VariablesView.prototype = {
return; return;
} }
this._searchboxContainer.remove(); this._searchboxContainer.remove();
this._searchboxNode.removeEventListener("input", this._onSearchboxInput, false); this._searchboxNode.removeEventListener("command", this._onSearchboxInput, false);
this._searchboxNode.removeEventListener("keypress", this._onSearchboxKeyPress, false); this._searchboxNode.removeEventListener("keypress", this._onSearchboxKeyPress, false);
this._searchboxContainer = null; this._searchboxContainer = null;