From 9a7c7d0ab3ad8bf0950030c781a08f33a8b14b9c Mon Sep 17 00:00:00 2001 From: Fred Lin Date: Tue, 30 Aug 2016 15:34:12 +0800 Subject: [PATCH] Bug 1272364 - [rep] Remove role presentation to let vision inpaired hear it. r=linclark MozReview-Commit-ID: DKfnNWs0n8W --HG-- extra : rebase_source : d9dc5f2a8facb19b1a77cea717fa0f626a9b8ff5 --- devtools/client/shared/components/reps/array.js | 2 -- devtools/client/shared/components/reps/grip-array.js | 2 -- devtools/client/shared/components/reps/grip.js | 3 --- devtools/client/shared/components/reps/object.js | 2 -- devtools/client/shared/components/reps/prop-rep.js | 12 ++++-------- 5 files changed, 4 insertions(+), 17 deletions(-) diff --git a/devtools/client/shared/components/reps/array.js b/devtools/client/shared/components/reps/array.js index 620a8a415b0b..70e1baa6571c 100644 --- a/devtools/client/shared/components/reps/array.js +++ b/devtools/client/shared/components/reps/array.js @@ -139,13 +139,11 @@ define(function (require, exports, module) { className: "objectBox objectBox-array"}, objectLink({ className: "arrayLeftBracket", - role: "presentation", object: object }, brackets.left), items, objectLink({ className: "arrayRightBracket", - role: "presentation", object: object }, brackets.right), DOM.span({ diff --git a/devtools/client/shared/components/reps/grip-array.js b/devtools/client/shared/components/reps/grip-array.js index ed7ecc5f9923..edec087c20a7 100644 --- a/devtools/client/shared/components/reps/grip-array.js +++ b/devtools/client/shared/components/reps/grip-array.js @@ -127,13 +127,11 @@ define(function (require, exports, module) { title, objectLink({ className: "arrayLeftBracket", - role: "presentation", object: object }, brackets.left), items, objectLink({ className: "arrayRightBracket", - role: "presentation", object: object }, brackets.right), span({ diff --git a/devtools/client/shared/components/reps/grip.js b/devtools/client/shared/components/reps/grip.js index 51dd1ca6fa3e..e6b8e187b908 100644 --- a/devtools/client/shared/components/reps/grip.js +++ b/devtools/client/shared/components/reps/grip.js @@ -177,7 +177,6 @@ define(function (require, exports, module) { this.getTitle(object), objectLink({ className: "objectLeftBrace", - role: "presentation", object: object }, "") ) @@ -189,13 +188,11 @@ define(function (require, exports, module) { this.getTitle(object), objectLink({ className: "objectLeftBrace", - role: "presentation", object: object }, " { "), props, objectLink({ className: "objectRightBrace", - role: "presentation", object: object }, " }") ) diff --git a/devtools/client/shared/components/reps/object.js b/devtools/client/shared/components/reps/object.js index 3af647568e9b..c58e6a305ffa 100644 --- a/devtools/client/shared/components/reps/object.js +++ b/devtools/client/shared/components/reps/object.js @@ -149,13 +149,11 @@ define(function (require, exports, module) { this.getTitle(object), objectLink({ className: "objectLeftBrace", - role: "presentation", object: object }, " { "), props, objectLink({ className: "objectRightBrace", - role: "presentation", object: object }, " }") ) diff --git a/devtools/client/shared/components/reps/prop-rep.js b/devtools/client/shared/components/reps/prop-rep.js index 45ddb25b873c..37dad97a1e7a 100644 --- a/devtools/client/shared/components/reps/prop-rep.js +++ b/devtools/client/shared/components/reps/prop-rep.js @@ -37,16 +37,12 @@ define(function (require, exports, module) { "className": "nodeName"}, this.props.name), span({ - "className": "objectEqual", - role: "presentation"}, - this.props.equal - ), + "className": "objectEqual" + }, this.props.equal), Rep(this.props), span({ - "className": "objectComma", - role: "presentation"}, - this.props.delim - ) + "className": "objectComma" + }, this.props.delim) ) ); }