Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-28 21:28:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1683244 - Part 1: Fix the issue that save As of multiple selected links in PageInfo media tab doesn't work. r=smaug

Browse Source 
The root cause is that it doesn't pass the cookieJarSettings parameter
when calling the internalSave() in pageInfo.js. This patch fixes this by
passing the correct cookieJarSettings which was passed via the
'PageInfo:getData' message.

Differential Revision: https://phabricator.services.mozilla.com/D100130
This commit is contained in:
Tim Huang 2020-12-19 22:51:04 +00:00
parent 5a96f35156
commit 9b272a4cb1
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
browser/actors/PageInfoChild.jsm
View File

@ -10,6 +10,7 @@ const { XPCOMUtils } = ChromeUtils.import(
);
XPCOMUtils.defineLazyModuleGetters(this, {
E10SUtils: "resource://gre/modules/E10SUtils.jsm",
PrivateBrowsingUtils: "resource://gre/modules/PrivateBrowsingUtils.jsm",
setTimeout: "resource://gre/modules/Timer.jsm",
});
@ -90,6 +91,9 @@ class PageInfoChild extends JSWindowActorChild {
docInfo.characterSet = document.characterSet;
docInfo.lastModified = document.lastModified;
docInfo.principal = document.nodePrincipal;
docInfo.cookieJarSettings = E10SUtils.serializeCookieJarSettings(
document.cookieJarSettings
);
let documentURIObject = {};
documentURIObject.spec = document.documentURIObject.spec;

9
browser/base/content/pageinfo/pageInfo.js
View File

@ -712,6 +712,9 @@ function saveMedia() {
true,
Services.io.newURI(item.baseURI)
);
let cookieJarSettings = E10SUtils.deserializeCookieJarSettings(
gDocInfo.cookieJarSettings
);
saveURL(
url,
null,
@ -719,7 +722,7 @@ function saveMedia() {
false,
false,
referrerInfo,
null,
cookieJarSettings,
null,
gDocInfo.isContentWindowPrivate,
gDocInfo.principal
@ -736,6 +739,9 @@ function saveMedia() {
true,
aBaseURI
);
let cookieJarSettings = E10SUtils.deserializeCookieJarSettings(
gDocInfo.cookieJarSettings
);
internalSave(
aURIString,
null,
@ -746,6 +752,7 @@ function saveMedia() {
"SaveImageTitle",
aChosenData,
referrerInfo,
cookieJarSettings,
null,
false,
null,