Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 05:11:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1863837 Part 7 - Use table frame's writing-mode in some helpers. r=layout-reviewers,emilio

Browse Source 
Table frame and its table row group children have the same writing-mode [1], so
this patch doesn't change behavior.

Since these helpers use data such as `TableReflowInput::mAvailSize`, which is in
table's writing-mode. Let's change these `wm` variables to initialize from
`GetWritingMode()` to avoid confusion.

[1] https://searchfox.org/mozilla-central/rev/02841791400cf7cf5760c0cfaf31f5d772624253/layout/tables/nsTableRowGroupFrame.h#54

Differential Revision: https://phabricator.services.mozilla.com/D193146
This commit is contained in:
Ting-Yu Lin 2023-11-13 22:36:15 +00:00
parent 31a87e10e6
commit 9b80a327a8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
layout/tables/nsTableFrame.cpp
View File

@ -2599,7 +2599,7 @@ static bool IsRepeatable(nscoord aFrameBSize, nscoord aPageBSize) {
nscoord nsTableFrame::SetupHeaderFooterChild(
const TableReflowInput& aReflowInput, nsTableRowGroupFrame* aFrame) {
nsPresContext* presContext = PresContext();
WritingMode wm = aFrame->GetWritingMode();
const WritingMode wm = GetWritingMode();
const nscoord pageBSize =
LogicalSize(wm, presContext->GetPageSize()).BSize(wm);
@ -2629,7 +2629,7 @@ void nsTableFrame::PlaceRepeatedFooter(TableReflowInput& aReflowInput,
nsTableRowGroupFrame* aTfoot,
nscoord aFooterBSize) {
nsPresContext* presContext = PresContext();
WritingMode wm = aTfoot->GetWritingMode();
const WritingMode wm = GetWritingMode();
LogicalSize kidAvailSize = aReflowInput.mAvailSize;
kidAvailSize.BSize(wm) = aFooterBSize;