diff --git a/gfx/2d/2D.h b/gfx/2d/2D.h index 7d4c6e0d7970..6f509999ceaa 100644 --- a/gfx/2d/2D.h +++ b/gfx/2d/2D.h @@ -979,7 +979,7 @@ public: } #ifdef USE_SKIA_GPU - virtual bool InitWithGrContext(GrContext* aGrContext, + virtual void InitWithGrContext(GrContext* aGrContext, const IntSize &aSize, SurfaceFormat aFormat) { diff --git a/gfx/2d/DrawTargetSkia.cpp b/gfx/2d/DrawTargetSkia.cpp index 1b78bcc09625..5c24b5727758 100644 --- a/gfx/2d/DrawTargetSkia.cpp +++ b/gfx/2d/DrawTargetSkia.cpp @@ -659,7 +659,7 @@ DrawTargetSkia::Init(const IntSize &aSize, SurfaceFormat aFormat) } #ifdef USE_SKIA_GPU -bool +void DrawTargetSkia::InitWithGrContext(GrContext* aGrContext, const IntSize &aSize, SurfaceFormat aFormat) @@ -681,17 +681,12 @@ DrawTargetSkia::InitWithGrContext(GrContext* aGrContext, targetDescriptor.fSampleCnt = 0; SkAutoTUnref skiaTexture(mGrContext->createUncachedTexture(targetDescriptor, NULL, 0)); - if (!skiaTexture) { - return false; - } mTexture = (uint32_t)skiaTexture->getTextureHandle(); SkAutoTUnref device(new SkGpuDevice(mGrContext.get(), skiaTexture->asRenderTarget())); SkAutoTUnref canvas(new SkCanvas(device.get())); mCanvas = canvas.get(); - - return true; } #endif diff --git a/gfx/2d/DrawTargetSkia.h b/gfx/2d/DrawTargetSkia.h index ad40f12ad3fa..c8efe7fef529 100644 --- a/gfx/2d/DrawTargetSkia.h +++ b/gfx/2d/DrawTargetSkia.h @@ -106,7 +106,7 @@ public: void Init(unsigned char* aData, const IntSize &aSize, int32_t aStride, SurfaceFormat aFormat); #ifdef USE_SKIA_GPU - bool InitWithGrContext(GrContext* aGrContext, + void InitWithGrContext(GrContext* aGrContext, const IntSize &aSize, SurfaceFormat aFormat) MOZ_OVERRIDE; #endif diff --git a/gfx/2d/Factory.cpp b/gfx/2d/Factory.cpp index 2bd18e472ef5..ce491502c888 100644 --- a/gfx/2d/Factory.cpp +++ b/gfx/2d/Factory.cpp @@ -590,10 +590,9 @@ Factory::CreateDrawTargetSkiaWithGrContext(GrContext* aGrContext, const IntSize &aSize, SurfaceFormat aFormat) { - RefPtr newTarget = new DrawTargetSkia(); - if (!newTarget->InitWithGrContext(aGrContext, aSize, aFormat)) { - return nullptr; - } + DrawTargetSkia* newDrawTargetSkia = new DrawTargetSkia(); + newDrawTargetSkia->InitWithGrContext(aGrContext, aSize, aFormat); + RefPtr newTarget = newDrawTargetSkia; return newTarget; }