Bug 1030740 - Add return statements inadvertently omitted from Bug 1025937. r=mcomella

This commit is contained in:
Richard Newman 2014-06-26 09:48:48 -07:00
parent 0e0a47e9f3
commit 9bd97eea31
7 changed files with 13 additions and 6 deletions

View File

@ -122,7 +122,8 @@ public class AnnouncementsBroadcastService extends BackgroundService {
// Intent can be null. Bug 1025937.
if (intent == null) {
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
return;
}
final String action = intent.getAction();

View File

@ -120,7 +120,8 @@ public class AnnouncementsService extends BackgroundService implements Announcem
// Intent can be null. Bug 1025937.
if (intent == null) {
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
return;
}
Logger.debug(LOG_TAG, "Running AnnouncementsService.");

View File

@ -102,7 +102,8 @@ public class HealthReportBroadcastService extends BackgroundService {
// Intent can be null. Bug 1025937.
if (intent == null) {
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
return;
}
// The same intent can be handled by multiple methods so do not short-circuit evaluate.

View File

@ -42,7 +42,8 @@ public class HealthReportPruneService extends BackgroundService {
// Intent can be null. Bug 1025937.
if (intent == null) {
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
return;
}
Logger.debug(LOG_TAG, "Handling prune intent.");

View File

@ -45,7 +45,8 @@ public class HealthReportUploadService extends BackgroundService {
// Intent can be null. Bug 1025937.
if (intent == null) {
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
return;
}
if (HealthReportConstants.UPLOAD_FEATURE_DISABLED) {

View File

@ -31,7 +31,8 @@ public class FxAccountDeletedService extends IntentService {
protected void onHandleIntent(final Intent intent) {
// Intent can, in theory, be null. Bug 1025937.
if (intent == null) {
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
return;
}
final Context context = this;

View File

@ -35,6 +35,7 @@ public class SyncAccountDeletedService extends IntentService {
// Intent can, in theory, be null. Bug 1025937.
if (intent == null) {
Logger.debug(LOG_TAG, "Short-circuiting on null intent.");
return;
}
final Context context = this;