Bug 1198168 - Since we're now checking the end time of the last chunk, make it inclusive. r=padenot

Bug 1600063 changed the chunk-dropping logic from dropping when we had *started*
playing a chunk, to when we had *finished* playing a chunk -- i.e., started
playing the next chunk.

But when a chunk is the very last chunk in the media resource, we cannot start
playing the next chunk, because there is no next chunk. Making this check
inclusive seems reasonable.

Differential Revision: https://phabricator.services.mozilla.com/D57374

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Andreas Pehrson 2019-12-17 15:51:49 +00:00
parent bffa660d30
commit 9c1206334a

View File

@ -945,7 +945,7 @@ void DecodedStream::NotifyOutput(int64_t aTime) {
// Remove audio samples that have been played by MTG from the queue.
RefPtr<AudioData> a = mAudioQueue.PeekFront();
for (; a && a->GetEndTime() < currentTime;) {
for (; a && a->GetEndTime() <= currentTime;) {
LOG_DS(LogLevel::Debug, "Dropping audio [%" PRId64 ",%" PRId64 "]",
a->mTime.ToMicroseconds(), a->GetEndTime().ToMicroseconds());
RefPtr<AudioData> releaseMe = mAudioQueue.PopFront();