Bug 1444490 Declare classses (and one method) in network/ final to reduce virtual function calls r=nwgh

MozReview-Commit-ID: 4oaazbPhpbc

--HG--
extra : rebase_source : 7c01066363605c64fc76332686b2c4d9c2af6518

netwerk/base/Dashboard.cpp

@@ -285,7 +285,7 @@ public:
 NS_IMPL_ISUPPORTS0(LookupArgument)
 
 
-class LookupHelper
+class LookupHelper final
     : public nsIDNSListener
 {
     virtual ~LookupHelper()

netwerk/base/LoadContextInfo.h

@@ -13,7 +13,7 @@ class nsILoadContext;
 namespace mozilla {
 namespace net {
 
-class LoadContextInfo : public nsILoadContextInfo
+class LoadContextInfo final : public nsILoadContextInfo
 {
 public:
   NS_DECL_THREADSAFE_ISUPPORTS

netwerk/base/NetworkActivityMonitor.h

@@ -55,8 +55,9 @@ private:
 };
 
 
-class NetworkActivityMonitor: public nsITimerCallback
-                            , public nsINamed
+class NetworkActivityMonitor final
+    : public nsITimerCallback
+    , public nsINamed
 {
 public:
   enum Direction {

netwerk/base/Predictor.h

@@ -37,12 +37,13 @@ namespace net {
 class nsHttpRequestHead;
 class nsHttpResponseHead;
 
-class Predictor : public nsINetworkPredictor
-                , public nsIObserver
-                , public nsISpeculativeConnectionOverrider
-                , public nsIInterfaceRequestor
-                , public nsICacheEntryMetaDataVisitor
-                , public nsINetworkPredictorVerifier
+class Predictor final
+  : public nsINetworkPredictor
+  , public nsIObserver
+  , public nsISpeculativeConnectionOverrider
+  , public nsIInterfaceRequestor
+  , public nsICacheEntryMetaDataVisitor
+  , public nsINetworkPredictorVerifier
 {
 public:
   NS_DECL_ISUPPORTS

netwerk/base/nsBufferedStreams.h

@@ -61,13 +61,14 @@ protected:
 
 ////////////////////////////////////////////////////////////////////////////////
 
-class nsBufferedInputStream : public nsBufferedStream,
-                              public nsIBufferedInputStream,
-                              public nsIStreamBufferAccess,
-                              public nsIIPCSerializableInputStream,
-                              public nsIAsyncInputStream,
-                              public nsIInputStreamCallback,
-                              public nsICloneableInputStream
+class nsBufferedInputStream final
+    : public nsBufferedStream,
+      public nsIBufferedInputStream,
+      public nsIStreamBufferAccess,
+      public nsIIPCSerializableInputStream,
+      public nsIAsyncInputStream,
+      public nsIInputStreamCallback,
+      public nsICloneableInputStream
 {
 public:
     NS_DECL_ISUPPORTS_INHERITED

netwerk/base/nsSimpleURI.h

@@ -78,7 +78,7 @@ protected:
     virtual nsresult SetSpecInternal(const nsACString &input);
     virtual nsresult SetScheme(const nsACString &input);
     virtual nsresult SetUserPass(const nsACString &input);
-    virtual nsresult SetUsername(const nsACString &input);
+    nsresult SetUsername(const nsACString &input);
     virtual nsresult SetPassword(const nsACString &input);
     virtual nsresult SetHostPort(const nsACString &aValue);
     virtual nsresult SetHost(const nsACString &input);

netwerk/cache2/CacheFileChunk.h

@@ -134,8 +134,9 @@ public:
   nsTArray<ChunkListenerItem *> mItems;
 };
 
-class CacheFileChunk : public CacheFileIOListener
-                     , public CacheMemoryConsumer
+class CacheFileChunk final
+  : public CacheFileIOListener
+  , public CacheMemoryConsumer
 {
 public:
   NS_DECL_THREADSAFE_ISUPPORTS

netwerk/cache2/CacheFileIOManager.h

@@ -43,7 +43,7 @@ class CacheFileHandlesEntry;
 #define TRASH_DIR   "trash"
 
 
-class CacheFileHandle : public nsISupports
+class CacheFileHandle final : public nsISupports
 {
 public:
   enum class PinningStatus : uint32_t {
@@ -259,8 +259,9 @@ public:
 NS_DEFINE_STATIC_IID_ACCESSOR(CacheFileIOListener, CACHEFILEIOLISTENER_IID)
 
 
-class CacheFileIOManager : public nsITimerCallback
-                         , public nsINamed
+class CacheFileIOManager final
+  : public nsITimerCallback
+  , public nsINamed
 {
 public:
   NS_DECL_THREADSAFE_ISUPPORTS

netwerk/cache2/CacheFileMetadata.h

@@ -123,8 +123,9 @@ NS_DEFINE_STATIC_IID_ACCESSOR(CacheFileMetadataListener,
                               CACHEFILEMETADATALISTENER_IID)
 
 
-class CacheFileMetadata : public CacheFileIOListener
-                        , public CacheMemoryConsumer
+class CacheFileMetadata final
+  : public CacheFileIOListener
+  , public CacheMemoryConsumer
 {
 public:
   NS_DECL_THREADSAFE_ISUPPORTS

netwerk/cache2/CacheIOThread.h

@@ -28,7 +28,7 @@ namespace detail {
 class BlockingIOWatcher;
 }
 
-class CacheIOThread : public nsIThreadObserver
+class CacheIOThread final : public nsIThreadObserver
 {
   virtual ~CacheIOThread();
 

netwerk/cache2/CacheIndex.cpp

@@ -178,7 +178,7 @@ private:
   bool                 mDoNotSearchInUpdates;
 };
 
-class FileOpenHelper : public CacheFileIOListener
+class FileOpenHelper final : public CacheFileIOListener
 {
 public:
   NS_DECL_THREADSAFE_ISUPPORTS

netwerk/cache2/CacheIndex.h

@@ -666,8 +666,9 @@ private:
 #endif
 };
 
-class CacheIndex : public CacheFileIOListener
-                 , public nsIRunnable
+class CacheIndex final
+  : public CacheFileIOListener
+  , public nsIRunnable
 {
 public:
   NS_DECL_THREADSAFE_ISUPPORTS

netwerk/cookie/nsCookie.h

@@ -27,7 +27,7 @@ using mozilla::OriginAttributes;
  * implementation
  ******************************************************************************/
 
-class nsCookie : public nsICookie2
+class nsCookie final : public nsICookie2
 {
   public:
     // nsISupports

netwerk/protocol/http/AlternateServices.h

@@ -142,7 +142,7 @@ private:
   nsCOMPtr<nsIInterfaceRequestor> mCallbacks;
 };
 
-class TransactionObserver : public nsIStreamListener
+class TransactionObserver final : public nsIStreamListener
 {
 public:
   NS_DECL_THREADSAFE_ISUPPORTS

netwerk/protocol/http/nsHttpConnectionInfo.h

@@ -32,7 +32,7 @@ namespace mozilla { namespace net {
 
 extern LazyLogModule gHttpLog;
 
-class nsHttpConnectionInfo: public ARefBase
+class nsHttpConnectionInfo final : public ARefBase
 {
 public:
     nsHttpConnectionInfo(const nsACString &originHost,

netwerk/protocol/http/nsHttpConnectionMgr.h

@@ -506,7 +506,7 @@ private:
     };
     friend class nsHalfOpenSocket;
 
-    class PendingTransactionInfo : public ARefBase
+    class PendingTransactionInfo final : public ARefBase
     {
     public:
         explicit PendingTransactionInfo(nsHttpTransaction * trans)

netwerk/protocol/res/ExtensionProtocolHandler.cpp

@@ -137,7 +137,7 @@ class ExtensionStreamGetter : public RefCounted<ExtensionStreamGetter>
     bool mIsJarChannel;
 };
 
-class ExtensionJARFileOpener : public nsISupports
+class ExtensionJARFileOpener final : public nsISupports
 {
 public:
   ExtensionJARFileOpener(nsIFile* aFile,

netwerk/test/TestCommon.h

@@ -11,7 +11,7 @@
 
 //-----------------------------------------------------------------------------
 
-class WaitForCondition : public nsIRunnable
+class WaitForCondition final : public nsIRunnable
 {
 public:
   NS_DECL_THREADSAFE_ISUPPORTS