Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-03 02:25:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1063359 - Unconditionally use -Wl,--no-as-needed when building with GNU ld/gold. r=mshal

Browse Source
This commit is contained in:
Mike Hommey 2015-07-23 18:37:47 +09:00
parent 39841c1702
commit 9ca903bc81
2 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
widget/gtk/mozgtk/gtk2/moz.build
View File

@ -14,11 +14,15 @@ SharedLibrary('mozgtk2')
SONAME = 'mozgtk'
# If LDFLAGS contains -Wl,--as-needed, we need to add -Wl,--no-as-needed
# before the gtk libraries, otherwise the linker will drop those dependencies
# because no symbols are used from them. But those dependencies need to be
# kept for things to work properly.
if '-Wl,--as-needed' in CONFIG['OS_LDFLAGS']:
# If LDFLAGS contains -Wl,--as-needed or if it's the default for the toolchain,
# we need to add -Wl,--no-as-needed before the gtk libraries, otherwise the
# linker will drop those dependencies because no symbols are used from them.
# But those dependencies need to be kept for things to work properly.
# Ideally, we'd only add -Wl,--no-as-needed if necessary, but it's just simpler
# to add it unconditionally. This library is also simple enough that forcing
# -Wl,--as-needed after the gtk libraries is not going to make a significant
# difference.
if CONFIG['GCC_USE_GNU_LD']:
no_as_needed = ['-Wl,--no-as-needed']
as_needed = ['-Wl,--as-needed']
else:

14
widget/gtk/mozgtk/gtk3/moz.build
View File

@ -14,11 +14,15 @@ SharedLibrary('mozgtk')
SONAME = 'mozgtk'
# If LDFLAGS contains -Wl,--as-needed, we need to add -Wl,--no-as-needed
# before the gtk libraries, otherwise the linker will drop those dependencies
# because no symbols are used from them. But those dependencies need to be
# kept for things to work properly.
if '-Wl,--as-needed' in CONFIG['OS_LDFLAGS']:
# If LDFLAGS contains -Wl,--as-needed or if it's the default for the toolchain,
# we need to add -Wl,--no-as-needed before the gtk libraries, otherwise the
# linker will drop those dependencies because no symbols are used from them.
# But those dependencies need to be kept for things to work properly.
# Ideally, we'd only add -Wl,--no-as-needed if necessary, but it's just simpler
# to add it unconditionally. This library is also simple enough that forcing
# -Wl,--as-needed after the gtk libraries is not going to make a significant
# difference.
if CONFIG['GCC_USE_GNU_LD']:
no_as_needed = ['-Wl,--no-as-needed']
as_needed = ['-Wl,--as-needed']
else: