Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-26 20:30:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1672087 - P1. Remove unused value. r=mattwoodrow

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D98570
This commit is contained in:
Jean-Yves Avenard 2020-12-04 00:59:04 +00:00
parent 4dc8612fed
commit 9cf6c54ce4
4 changed files with 2 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
dom/media/MediaResult.h
View File

@ -55,16 +55,9 @@ class MediaResult {
mMessage.IsEmpty() ? "" : " - ", mMessage.get());
}
void SetGPUCrashTimeStamp(const TimeStamp& aTime) {
mGPUCrashTimeStamp = aTime;
}
const TimeStamp& GPUCrashTimeStamp() const { return mGPUCrashTimeStamp; }
private:
nsresult mCode;
nsCString mMessage;
TimeStamp
mGPUCrashTimeStamp; // Used in bug 1393399 for temporary telemetry usage.
};
#ifdef _MSC_VER

6
dom/media/ipc/MediaIPCUtils.h
View File

@ -175,18 +175,14 @@ struct ParamTraits<mozilla::MediaResult> {
static void Write(Message* aMsg, const paramType& aParam) {
WriteParam(aMsg, aParam.Code());
WriteParam(aMsg, aParam.Message());
WriteParam(aMsg, aParam.GPUCrashTimeStamp());
}
static bool Read(const Message* aMsg, PickleIterator* aIter,
paramType* aResult) {
nsresult result;
nsCString message;
mozilla::TimeStamp timeStamp;
if (ReadParam(aMsg, aIter, &result) && ReadParam(aMsg, aIter, &message) &&
ReadParam(aMsg, aIter, &timeStamp)) {
if (ReadParam(aMsg, aIter, &result) && ReadParam(aMsg, aIter, &message)) {
*aResult = paramType(result, std::move(message));
aResult->SetGPUCrashTimeStamp(timeStamp);
return true;
}
return false;

5
dom/media/ipc/RemoteDecoderChild.cpp
View File

@ -29,9 +29,7 @@ void RemoteDecoderChild::HandleRejectionError(
// thing and we can consider that the parent has crashed. The child can no
// longer be used.
// The GPU/RDD process crashed, record the time and send back to MFR for
// telemetry.
mRemoteProcessCrashTime = TimeStamp::Now();
// The GPU/RDD process crashed.
if (mRecreatedOnCrash) {
// Defer reporting an error until we've recreated the manager so that
// it'll be safe for MediaFormatReader to recreate decoders
@ -40,7 +38,6 @@ void RemoteDecoderChild::HandleRejectionError(
"RemoteDecoderChild::HandleRejectionError",
[self, callback = std::move(aCallback)]() {
MediaResult error(NS_ERROR_DOM_MEDIA_NEED_NEW_DECODER, __func__);
error.SetGPUCrashTimeStamp(self->mRemoteProcessCrashTime);
callback(error);
}));
return;

1
dom/media/ipc/RemoteDecoderChild.h
View File

@ -70,7 +70,6 @@ class RemoteDecoderChild : public ShmemRecycleAllocator<RemoteDecoderChild>,
void HandleRejectionError(
const ipc::ResponseRejectReason& aReason,
std::function<void(const MediaResult&)>&& aCallback);
TimeStamp mRemoteProcessCrashTime;
nsCString mHardwareAcceleratedReason;
nsCString mDescription;