Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 21:31:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1669982 - Add a test. r=botond

Browse Source 
Depends on D93494

Differential Revision: https://phabricator.services.mozilla.com/D93570
This commit is contained in:
Kartikaya Gupta 2020-10-14 20:59:35 +00:00
parent 6d7be02ed3
commit 9d6aa07b4f
4 changed files with 76 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
dom/base/nsDOMWindowUtils.cpp
View File

@ -6,6 +6,7 @@
#include "nsDOMWindowUtils.h"
#include "MobileViewportManager.h"
#include "mozilla/layers/CompositorBridgeChild.h"
#include "mozilla/layers/LayerTransactionChild.h"
#include "nsPresContext.h"
@ -4440,3 +4441,15 @@ nsDOMWindowUtils::GetEffectivelyThrottlesFrameRequests(bool* aResult) {
doc->ShouldThrottleFrameRequests();
return NS_OK;
}
NS_IMETHODIMP
nsDOMWindowUtils::ResetMobileViewportManager() {
if (RefPtr<PresShell> presShell = GetPresShell()) {
if (auto mvm = presShell->GetMobileViewportManager()) {
mvm->SetInitialViewport();
return NS_OK;
}
}
// Unable to reset, so let's error out
return NS_ERROR_FAILURE;
}

7
dom/interfaces/base/nsIDOMWindowUtils.idl
View File

@ -2012,6 +2012,13 @@ interface nsIDOMWindowUtils : nsISupports {
*/
bool isCssPropertyRecordedInUseCounter(in ACString aProperty);
/**
* Calls SetInitialViewport on the MobileViewportManager, which effectively
* causes it to refresh all of its internal state and update things that
* need updating.
*/
void resetMobileViewportManager();
/**
* NOTE: Currently works only on GTK+.
*/

55
gfx/layers/apz/test/mochitest/helper_checkerboard_zoom_during_load.html Normal file
View File

@ -0,0 +1,55 @@
<!DOCTYPE html>
<html lang="en"><head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8"><meta charset="utf-8">
<title>Testcase for checkerboarding after zooming during page load</title>
<script type="application/javascript" src="apz_test_utils.js"></script>
<script src="/tests/SimpleTest/paint_listener.js"></script>
<meta name="viewport" content="width=device-width"/>
<style>
body, html {
margin: 0;
}
</style>
<body>
<div style="height: 5000px; background-color: green"></div>
</body>
<script type="application/javascript">
// This function runs after page load, but simulates what might happen if
// the user does a zoom during page load. It's hard to actually do this
// during page load, because the specific behaviour depends on interleaving
// between paints and the load event which is hard to control from a test.
// So instead, we do the zoom after page load, and then trigger a MVM reset
// which simulates what happens during the pageload process.
async function test() {
var utils = SpecialPowers.getDOMWindowUtils(window);
// Make it so that the layout and visual viewports diverge. We do this by
// zooming and then moving the visual viewport.
utils.setResolutionAndScaleTo(2);
var x = window.innerWidth / 2;
var y = window.innerHeight / 2;
utils.scrollToVisual(x, y, utils.UPDATE_TYPE_MAIN_THREAD, utils.SCROLL_MODE_INSTANT);
dump("Done scrollToVisual\n");
// Next, kick off a paint transaction to APZ, so that it sets appropriate
// displayport margins with visual/layout adjustment factors.
await promiseApzFlushedRepaints();
// Once that's done, we want to trigger the MobileViewportManager to update
// the displayport margins.
dump("Resetting MVM...\n");
utils.resetMobileViewportManager();
// The bug is that at this point, paints end up checkerboarding because the
// MVM code to update the displayport margins doesn't preserve the layout
// adjustment factor needed.
utils.advanceTimeAndRefresh(0);
assertNotCheckerboarded(utils, utils.getViewId(document.scrollingElement), `Should not see checkerboarding`);
}
waitUntilApzStable()
.then(test)
.finally(subtestDone);
</script>

1
gfx/layers/apz/test/mochitest/test_group_checkerboarding.html
View File

@ -43,6 +43,7 @@
{ file: "helper_checkerboard_scrollinfo.html", prefs },
{ file: "helper_horizontal_checkerboard.html", "prefs": px_ratio_1_prefs },
{ file: "helper_checkerboard_no_multiplier.html", "prefs": no_multiplier_prefs },
{ file: "helper_checkerboard_zoom_during_load.html", "prefs": no_multiplier_prefs },
];
let isWindows = navigator.platform.indexOf("Win") == 0;