Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-02 22:37:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1493409 [wpt PR 13163] - [service-workers] Return value in cleanup, a=testonly

Browse Source 
Automatic update from web-platform-tests[service-workers] Return value in cleanup (#13163)

Previously, many tests un-registered service workers using the
testharness.js API `add_cleanup` without returning the promise which
tracked the operation. While this ensured the operation was started at
the completion of the test, it did not guarantee that the operation
would be completed before the test was considered "complete."

In automation scenarios where many tests are executed in rapid
succession, this enabled a race condition: the navigation could
interrupt the un-registration process. In order to account for the
possibility of registrations that persisted from previous test failures,
the tests included "setup" code to defensively un-register such workers.

The `Test#add_cleanup` method was recently extended to support
asynchronous "clean up" operations [1]. Use that API to ensure tests are
not considered "complete" until after service worker un-registration is
done.

[1] https://github.com/web-platform-tests/wpt/pull/8748
--

wpt-commits: 7897f9d5beff624590d2fc254d2a7eca6e2b1e8f
wpt-pr: 13163
This commit is contained in:
jugglinmike 2018-09-26 10:46:57 +00:00 committed by moz-wptsync-bot
parent c6cc61d0c2
commit 9e157c27ca
9 changed files with 11 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
testing/web-platform/tests/service-workers/service-worker/fetch-request-xhr-sync.https.html
View File

@ -14,7 +14,7 @@ promise_test(function(t) {
return service_worker_unregister_and_register(t, url, scope)
.then(function(registration) {
t.add_cleanup(function() {
registration.unregister();
return registration.unregister();
});
return wait_for_state(t, registration.installing, 'activated');

2
testing/web-platform/tests/service-workers/service-worker/interfaces-window.https.html
View File

@ -40,7 +40,7 @@ promise_test(async (t) => {
t, 'resources/empty-worker.js', scope)
.then(function(registration) {
t.add_cleanup(function() {
registration.unregister();
return registration.unregister();
});
window.registrationInstance = registration;

2
testing/web-platform/tests/service-workers/service-worker/onactivate-script-error.https.html
View File

@ -35,7 +35,7 @@ function make_test(name, script) {
registration = r;
t.add_cleanup(function() {
r.unregister();
return r.unregister();
});
return wait_for_install(registration.installing);

18
testing/web-platform/tests/service-workers/service-worker/postmessage.https.html
View File

@ -13,11 +13,7 @@ promise_test(t => {
return service_worker_unregister_and_register(t, script, scope)
.then(r => {
// TODO: return the Promise created by `r.unregister`once
// `testharness.js` has been updated to honor thenables returned by
// cleanup functions.
// See https://github.com/web-platform-tests/wpt/pull/8748
t.add_cleanup(() => { r.unregister(); });
t.add_cleanup(() => r.unregister());
registration = r;
worker = registration.installing;
@ -66,11 +62,7 @@ promise_test(t => {
return service_worker_unregister_and_register(t, script, scope)
.then(r => {
// TODO: return the Promise created by `r.unregister`once
// `testharness.js` has been updated to honor thenables returned by
// cleanup functions.
// See https://github.com/web-platform-tests/wpt/pull/8748
t.add_cleanup(() => { r.unregister(); });
t.add_cleanup(() => r.unregister());
var ab = text_encoder.encode(message);
assert_equals(ab.byteLength, message.length);
@ -110,11 +102,7 @@ promise_test(t => {
return service_worker_unregister_and_register(t, script, scope)
.then(r => {
// TODO: return the Promise created by `r.unregister`once
// `testharness.js` has been updated to honor thenables returned by
// cleanup functions.
// See https://github.com/web-platform-tests/wpt/pull/8748
t.add_cleanup(() => { r.unregister(); });
t.add_cleanup(() => r.unregister());
var channel = new MessageChannel;
port = channel.port1;

2
testing/web-platform/tests/service-workers/service-worker/registration-service-worker-attributes.https.html
View File

@ -14,7 +14,7 @@ promise_test(function(t) {
return service_worker_unregister_and_register(t, worker_url, scope)
.then(function(r) {
t.add_cleanup(function() {
r.unregister();
return r.unregister();
});
registration = r;
newest_worker = registration.installing;

2
testing/web-platform/tests/service-workers/service-worker/resources/worker-testharness.js
View File

@ -20,7 +20,7 @@ importScripts('/resources/testharness.js');
var cache_name = self.location.pathname + '/' + uniquifier;
test.add_cleanup(function() {
self.caches.delete(cache_name);
return self.caches.delete(cache_name);
});
return self.caches.delete(cache_name)

2
testing/web-platform/tests/service-workers/service-worker/skip-waiting-using-registration.https.html
View File

@ -51,7 +51,7 @@ promise_test(function(t) {
.then(function(registration) {
sw_registration = registration;
t.add_cleanup(function() {
registration.unregister();
return registration.unregister();
});
return saw_controllerchanged;
})

2
testing/web-platform/tests/service-workers/service-worker/skip-waiting-without-using-registration.https.html
View File

@ -27,7 +27,7 @@ promise_test(function(t) {
.then(function(registration) {
sw_registration = registration;
t.add_cleanup(function() {
registration.unregister();
return registration.unregister();
});
return wait_for_state(t, registration.installing, 'activated');
})

2
testing/web-platform/tests/service-workers/service-worker/synced-state.https.html
View File

@ -33,7 +33,7 @@ promise_test(function(t) {
worker = registration.installing;
t.add_cleanup(function() {
r.unregister();
return r.unregister();
});
return nextChange(worker);