From 9e4c9d88a160be7573b2173fc6347b785a1281b7 Mon Sep 17 00:00:00 2001 From: Andrew Osmond Date: Wed, 14 Jun 2017 11:40:00 -0400 Subject: [PATCH] Bug 1365927 - Part 6. Remove CompositorThreadHolder reference from CompositorBridgeParent. r=dvander --- gfx/layers/ipc/CompositorBridgeParent.cpp | 3 --- gfx/layers/ipc/CompositorBridgeParent.h | 1 - gfx/layers/ipc/CrossProcessCompositorBridgeParent.cpp | 1 - gfx/layers/ipc/CrossProcessCompositorBridgeParent.h | 1 - 4 files changed, 6 deletions(-) diff --git a/gfx/layers/ipc/CompositorBridgeParent.cpp b/gfx/layers/ipc/CompositorBridgeParent.cpp index 689870520d91..020775880b2f 100644 --- a/gfx/layers/ipc/CompositorBridgeParent.cpp +++ b/gfx/layers/ipc/CompositorBridgeParent.cpp @@ -336,7 +336,6 @@ CompositorBridgeParent::CompositorBridgeParent(CompositorManagerParent* aManager , mRootLayerTreeID(0) , mOverrideComposeReadiness(false) , mForceCompositionTask(nullptr) - , mCompositorThreadHolder(CompositorThreadHolder::GetSingleton()) , mCompositorScheduler(nullptr) , mAnimationStorage(nullptr) , mPaintTime(TimeDuration::Forever()) @@ -494,8 +493,6 @@ CompositorBridgeParent::RecvWillClose() void CompositorBridgeParent::DeferredDestroy() { MOZ_ASSERT(!NS_IsMainThread()); - MOZ_ASSERT(mCompositorThreadHolder); - mCompositorThreadHolder = nullptr; mSelfRef = nullptr; } diff --git a/gfx/layers/ipc/CompositorBridgeParent.h b/gfx/layers/ipc/CompositorBridgeParent.h index 0d0f6fed3d2b..99d301b8f96b 100644 --- a/gfx/layers/ipc/CompositorBridgeParent.h +++ b/gfx/layers/ipc/CompositorBridgeParent.h @@ -598,7 +598,6 @@ protected: RefPtr mApzcTreeManager; - RefPtr mCompositorThreadHolder; RefPtr mCompositorScheduler; // This makes sure the compositorParent is not destroyed before receiving // confirmation that the channel is closed. diff --git a/gfx/layers/ipc/CrossProcessCompositorBridgeParent.cpp b/gfx/layers/ipc/CrossProcessCompositorBridgeParent.cpp index d3996a18e938..9d48dc3339ac 100644 --- a/gfx/layers/ipc/CrossProcessCompositorBridgeParent.cpp +++ b/gfx/layers/ipc/CrossProcessCompositorBridgeParent.cpp @@ -480,7 +480,6 @@ CrossProcessCompositorBridgeParent::GetCompositionManager(LayerTransactionParent void CrossProcessCompositorBridgeParent::DeferredDestroy() { - mCompositorThreadHolder = nullptr; mSelfRef = nullptr; } diff --git a/gfx/layers/ipc/CrossProcessCompositorBridgeParent.h b/gfx/layers/ipc/CrossProcessCompositorBridgeParent.h index 2706f4e6d7bc..6da58d97e96b 100644 --- a/gfx/layers/ipc/CrossProcessCompositorBridgeParent.h +++ b/gfx/layers/ipc/CrossProcessCompositorBridgeParent.h @@ -162,7 +162,6 @@ private: // ourself. This is released (deferred) in ActorDestroy(). RefPtr mSelfRef; - RefPtr mCompositorThreadHolder; // If true, we should send a RemotePaintIsReady message when the layer transaction // is received bool mNotifyAfterRemotePaint;