Bug 1786197 - Turn on ESLint rule for prefer-boolean-length-check for modules. r=valentin

Differential Revision: https://phabricator.services.mozilla.com/D155172

.eslintrc.js

@@ -480,7 +480,6 @@ module.exports = {
         "dom/**",
         "image/test/browser/browser_image.js",
         "layout/**",
-        "modules/**",
         "netwerk/**",
         "remote/**",
         "storage/test/unit/test_vacuum.js",

modules/libjar/test/unit/test_crx.js

@@ -38,6 +38,6 @@ function run_test() {
   zipreader.close();
   zipreader = null;
   Cu.forceGC();
-  Assert.ok(stream.read(1024).length > 0);
-  Assert.ok(dirstream.read(100).length > 0);
+  Assert.ok(!!stream.read(1024).length);
+  Assert.ok(!!dirstream.read(100).length);
 }

modules/libjar/test/unit/test_fault_handler.js

@@ -124,7 +124,7 @@ add_task(async function test() {
   Assert.throws(
     () => {
       while (true) {
-        Assert.ok(stream.read(1024).length > 0);
+        Assert.ok(!!stream.read(1024).length);
       }
     },
     /NS_ERROR_FAILURE/,

modules/libjar/test/unit/test_jarinput_stream_zipreader_reference.js

@@ -37,6 +37,6 @@ function run_test() {
   zipreader.close();
   zipreader = null;
   Cu.forceGC();
-  Assert.ok(stream.read(1024).length > 0);
-  Assert.ok(dirstream.read(100).length > 0);
+  Assert.ok(!!stream.read(1024).length);
+  Assert.ok(!!dirstream.read(100).length);
 }

modules/libmar/tests/unit/head_libmar.js

@@ -91,7 +91,7 @@ function run_tests(obj) {
  */
 function createMAR(outMAR, dataDir, files) {
   // You cannot create an empy MAR.
-  Assert.ok(files.length > 0);
+  Assert.ok(!!files.length);
 
   // Get an nsIProcess to the signmar binary.
   let process = Cc["@mozilla.org/process/util;1"].createInstance(Ci.nsIProcess);