Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-17 15:25:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 878435 - In asmjs mode, compare in uint32 mode only if both operands are unsigned. r=luke

Browse Source
This commit is contained in:
Benjamin Bouvier 2013-06-06 17:00:08 -07:00
parent e9ecd45e88
commit 9ee14f0649
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/src/ion/AsmJS.cpp
View File

@ -3985,7 +3985,7 @@ CheckComparison(FunctionCompiler &f, ParseNode *comp, MDefinition **def, Type *t
return false;
if ((lhsType.isSigned() && rhsType.isSigned()) || (lhsType.isUnsigned() && rhsType.isUnsigned())) {
MCompare::CompareType compareType = lhsType.isUnsigned()
MCompare::CompareType compareType = (lhsType.isUnsigned() && rhsType.isUnsigned())
? MCompare::Compare_UInt32
: MCompare::Compare_Int32;
*def = f.compare(lhsDef, rhsDef, comp->getOp(), compareType);

11
js/src/jit-test/tests/asm.js/testBug878435.js Normal file
View File

@ -0,0 +1,11 @@
function g()
{
"use asm";
function f()
{
return (0 > (0x80000000 | 0)) | 0;
}
return f;
}
assertEq(g()(), (0 > (0x80000000 | 0)) | 0);