Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-10 03:45:46 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1824465 - Part 22: Make PStreamFilter refcounted, r=extension-reviewers,kmag

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D173737
This commit is contained in:
Nika Layzell 2023-04-19 22:10:10 +00:00
parent ae78252f9f
commit 9f63845fe1
6 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
toolkit/components/extensions/webrequest/PStreamFilter.ipdl
View File

@ -7,7 +7,6 @@ include protocol PBackground;
namespace mozilla {
namespace extensions {
[ManualDealloc]
async protocol PStreamFilter
{
parent:

3
toolkit/components/extensions/webrequest/StreamFilter.cpp
View File

@ -103,9 +103,6 @@ void StreamFilter::FinishConnect(
if (aEndpoint.IsValid()) {
MOZ_RELEASE_ASSERT(aEndpoint.Bind(mActor));
mActor->RecvInitialized(true);
// IPC now owns this reference.
Unused << do_AddRef(mActor);
} else {
mActor->RecvInitialized(false);
}

4
toolkit/components/extensions/webrequest/StreamFilterChild.cpp
View File

@ -512,9 +512,5 @@ void StreamFilterChild::ActorDestroy(ActorDestroyReason aWhy) {
mStreamFilter = nullptr;
}
void StreamFilterChild::ActorDealloc() {
RefPtr<StreamFilterChild> self = dont_AddRef(this);
}
} // namespace extensions
} // namespace mozilla

4
toolkit/components/extensions/webrequest/StreamFilterChild.h
View File

@ -31,7 +31,7 @@ class StreamFilterChild final : public PStreamFilterChild,
friend class PStreamFilterChild;
public:
NS_INLINE_DECL_REFCOUNTING(StreamFilterChild)
NS_INLINE_DECL_REFCOUNTING(StreamFilterChild, final)
StreamFilterChild() : mState(State::Uninitialized), mReceivedOnStop(false) {}
@ -100,8 +100,6 @@ class StreamFilterChild final : public PStreamFilterChild,
IPCResult RecvResumed();
IPCResult RecvFlushData();
virtual void ActorDealloc() override;
void SetStreamFilter(StreamFilter* aStreamFilter) {
mStreamFilter = aStreamFilter;
}

7
toolkit/components/extensions/webrequest/StreamFilterParent.cpp
View File

@ -169,9 +169,6 @@ void StreamFilterParent::Attach(nsIChannel* aChannel,
}
self->Init(aChannel);
// IPC owns this reference now.
Unused << self.forget();
}
void StreamFilterParent::Disconnect(const nsACString& aReason) {
@ -814,10 +811,6 @@ void StreamFilterParent::ActorDestroy(ActorDestroyReason aWhy) {
}
}
void StreamFilterParent::ActorDealloc() {
RefPtr<StreamFilterParent> self = dont_AddRef(this);
}
NS_INTERFACE_MAP_BEGIN(StreamFilterParent)
NS_INTERFACE_MAP_ENTRY(nsIStreamListener)
NS_INTERFACE_MAP_ENTRY(nsIRequestObserver)

2
toolkit/components/extensions/webrequest/StreamFilterParent.h
View File

@ -102,8 +102,6 @@ class StreamFilterParent final : public PStreamFilterParent,
IPCResult RecvDisconnect();
IPCResult RecvDestroy();
virtual void ActorDealloc() override;
private:
bool IPCActive() {
return (mState != State::Closed && mState != State::Disconnecting &&