Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-03-02 22:37:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1675740 - Allow to skip the upload-symbols tasks. r=taskgraph-reviewers,aki

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D96782
This commit is contained in:
Mike Hommey 2020-11-12 04:35:48 +00:00
parent 56c565bb77
commit 9f6f422cd2
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
taskcluster/docs/attributes.rst
View File

@ -308,6 +308,12 @@ build kinds where the full crashsymbols should be enabled, set this attribute
to True. The full symbol packages will then be generated and uploaded on
release branches and on try.
skip-upload-crashsymbols
========================
Shippable/nightly builds are normally required to set enable-full-crashsymbols,
but in some limited corner cases (universal builds), that is not wanted, because
the symbols are uploaded independently already.
cron
====
Indicates that a task is meant to be run via cron tasks, and should not be run

5
taskcluster/taskgraph/transforms/upload_symbols.py
View File

@ -33,6 +33,7 @@ def check_nightlies(config, tasks):
config.params["project"] in RELEASE_PROJECTS
and dep.attributes.get("shippable")
and not dep.attributes.get("enable-full-crashsymbols")
and not dep.attributes.get("skip-upload-crashsymbols")
):
raise Exception(
"Shippable job %s should have enable-full-crashsymbols attribute "
@ -51,7 +52,9 @@ def fill_template(config, tasks):
task["label"] = dep.label + "-upload-symbols"
# Skip tasks where we don't have the full crashsymbols enabled
if not dep.attributes.get("enable-full-crashsymbols"):
if not dep.attributes.get("enable-full-crashsymbols") or dep.attributes.get(
"skip-upload-crashsymbols"
):
logger.debug("Skipping upload symbols task for %s", task["label"])
continue