Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 05:41:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1343718 - Don't display download progress when we don't know the download size in advance. r=chmanchester

Browse Source 
In most cases, the HTTP response for the download will contain the
content-length, but if some error happens (e.g. authentication error),
there might not be one, and the download fails with a TypeError for a
division by None, instead of failing with a more friendly error message
about the HTTP error.

--HG--
extra : rebase_source : f179142e69c9ca09b05ad2ff942753fd84da6a69
This commit is contained in:
Mike Hommey 2017-03-01 11:16:27 +09:00
parent 2f47399ef6
commit a07b022268
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
python/mozbuild/mozbuild/artifacts.py
View File

@ -718,6 +718,8 @@ class ArtifactCache(CacheManager):
dl = self._download_manager.download(url, fname) dl = self._download_manager.download(url, fname)
def download_progress(dl, bytes_so_far, total_size): def download_progress(dl, bytes_so_far, total_size):
if not total_size:
return
percent = (float(bytes_so_far) / total_size) * 100 percent = (float(bytes_so_far) / total_size) * 100
now = int(percent / 5) now = int(percent / 5)
if now == self._last_dl_update: if now == self._last_dl_update: