Bug 1280647 - Rename nsStyleDisplay member mFloats to mFloat. r=dholbert

Also rename mOriginalFloats to mOriginalFloat.

MozReview-Commit-ID: COfmU34CtJU

--HG--
extra : rebase_source : 5b203dd9f0161f353a4a0b95003afe4af1d1480e
This commit is contained in:
Ting-Yu Lin 2016-06-18 22:16:20 +01:00
parent ffc6d631d6
commit a178b8185c
5 changed files with 26 additions and 26 deletions

View File

@ -2004,13 +2004,13 @@ nsStylePosition::MaxBSizeDependsOnContainer(mozilla::WritingMode aWM) const
inline uint8_t
nsStyleDisplay::PhysicalFloats(mozilla::WritingMode aWM) const
{
if (mFloats == NS_STYLE_FLOAT_INLINE_START) {
if (mFloat == NS_STYLE_FLOAT_INLINE_START) {
return aWM.IsBidiLTR() ? NS_STYLE_FLOAT_LEFT : NS_STYLE_FLOAT_RIGHT;
}
if (mFloats == NS_STYLE_FLOAT_INLINE_END) {
if (mFloat == NS_STYLE_FLOAT_INLINE_END) {
return aWM.IsBidiLTR() ? NS_STYLE_FLOAT_RIGHT : NS_STYLE_FLOAT_LEFT;
}
return mFloats;
return mFloat;
}
inline uint8_t

View File

@ -911,7 +911,7 @@ already_AddRefed<CSSValue>
nsComputedDOMStyle::DoGetFloat()
{
RefPtr<nsROCSSPrimitiveValue> val = new nsROCSSPrimitiveValue;
val->SetIdent(nsCSSProps::ValueToKeywordEnum(StyleDisplay()->mFloats,
val->SetIdent(nsCSSProps::ValueToKeywordEnum(StyleDisplay()->mFloat,
nsCSSProps::kFloatKTable));
return val.forget();
}

View File

@ -5327,12 +5327,12 @@ nsRuleNode::ComputeDisplayData(void* aStartStruct,
COMPUTE_START_RESET(Display, display, parentDisplay)
// We may have ended up with aStartStruct's values of mDisplay and
// mFloats, but those may not be correct if our style data overrides
// mFloat, but those may not be correct if our style data overrides
// its position or float properties. Reset to mOriginalDisplay and
// mOriginalFloats; it if turns out we still need the display/floats
// adjustments we'll do them below.
// mOriginalFloat; if it turns out we still need the display/floats
// adjustments, we'll do them below.
display->mDisplay = display->mOriginalDisplay;
display->mFloats = display->mOriginalFloats;
display->mFloat = display->mOriginalFloat;
// Each property's index in this array must match its index in the
// const array |transitionPropInfo| above.
@ -6016,12 +6016,12 @@ nsRuleNode::ComputeDisplayData(void* aStartStruct,
// float: enum, inherit, initial
SetValue(*aRuleData->ValueForFloat(),
display->mFloats, conditions,
display->mFloat, conditions,
SETVAL_ENUMERATED | SETVAL_UNSET_INITIAL,
parentDisplay->mFloats,
parentDisplay->mFloat,
NS_STYLE_FLOAT_NONE);
// Save mFloats in mOriginalFloats in case we need it later
display->mOriginalFloats = display->mFloats;
// Save mFloat in mOriginalFloat in case we need it later
display->mOriginalFloat = display->mFloat;
// overflow-x: enum, inherit, initial
SetValue(*aRuleData->ValueForOverflowX(),
@ -6144,15 +6144,15 @@ nsRuleNode::ComputeDisplayData(void* aStartStruct,
// 1) if position is 'absolute' or 'fixed' then display must be
// block-level and float must be 'none'
EnsureBlockDisplay(display->mDisplay);
display->mFloats = NS_STYLE_FLOAT_NONE;
display->mFloat = NS_STYLE_FLOAT_NONE;
// Note that it's OK to cache this struct in the ruletree
// because it's fine as-is for any style context that points to
// it directly, and any use of it as aStartStruct (e.g. if a
// more specific rule sets "position: static") will use
// mOriginalDisplay and mOriginalFloats, which we have carefully
// mOriginalDisplay and mOriginalFloat, which we have carefully
// not changed.
} else if (display->mFloats != NS_STYLE_FLOAT_NONE) {
} else if (display->mFloat != NS_STYLE_FLOAT_NONE) {
// 2) if float is not none, and display is not none, then we must
// set a block-level 'display' type per CSS2.1 section 9.7.
EnsureBlockDisplay(display->mDisplay);

View File

@ -2832,8 +2832,8 @@ nsStyleDisplay::nsStyleDisplay(StyleStructContext aContext)
, mContain(NS_STYLE_CONTAIN_NONE)
, mAppearance(NS_THEME_NONE)
, mPosition(NS_STYLE_POSITION_STATIC)
, mFloats(NS_STYLE_FLOAT_NONE)
, mOriginalFloats(NS_STYLE_FLOAT_NONE)
, mFloat(NS_STYLE_FLOAT_NONE)
, mOriginalFloat(NS_STYLE_FLOAT_NONE)
, mBreakType(NS_STYLE_CLEAR_NONE)
, mBreakInside(NS_STYLE_PAGE_BREAK_AUTO)
, mBreakBefore(false)
@ -2894,8 +2894,8 @@ nsStyleDisplay::nsStyleDisplay(const nsStyleDisplay& aSource)
, mContain(aSource.mContain)
, mAppearance(aSource.mAppearance)
, mPosition(aSource.mPosition)
, mFloats(aSource.mFloats)
, mOriginalFloats(aSource.mOriginalFloats)
, mFloat(aSource.mFloat)
, mOriginalFloat(aSource.mOriginalFloat)
, mBreakType(aSource.mBreakType)
, mBreakInside(aSource.mBreakInside)
, mBreakBefore(aSource.mBreakBefore)
@ -2957,7 +2957,7 @@ nsStyleDisplay::CalcDifference(const nsStyleDisplay& aOther) const
|| mPosition != aOther.mPosition
|| mDisplay != aOther.mDisplay
|| mContain != aOther.mContain
|| (mFloats == NS_STYLE_FLOAT_NONE) != (aOther.mFloats == NS_STYLE_FLOAT_NONE)
|| (mFloat == NS_STYLE_FLOAT_NONE) != (aOther.mFloat == NS_STYLE_FLOAT_NONE)
|| mOverflowX != aOther.mOverflowX
|| mOverflowY != aOther.mOverflowY
|| mScrollBehavior != aOther.mScrollBehavior
@ -2995,7 +2995,7 @@ nsStyleDisplay::CalcDifference(const nsStyleDisplay& aOther) const
return nsChangeHint_ReconstructFrame;
}
if (mFloats != aOther.mFloats) {
if (mFloat != aOther.mFloat) {
// Changing which side we float on doesn't affect descendants directly
hint |= nsChangeHint_AllReflowHints &
~(nsChangeHint_ClearDescendantIntrinsics |
@ -3139,7 +3139,7 @@ nsStyleDisplay::CalcDifference(const nsStyleDisplay& aOther) const
if (!hint &&
(mOriginalDisplay != aOther.mOriginalDisplay ||
mOriginalFloats != aOther.mOriginalFloats ||
mOriginalFloat != aOther.mOriginalFloat ||
mTransitions != aOther.mTransitions ||
mTransitionTimingFunctionCount !=
aOther.mTransitionTimingFunctionCount ||

View File

@ -2513,9 +2513,9 @@ struct MOZ_NEEDS_MEMMOVABLE_MEMBERS nsStyleDisplay
uint8_t mContain; // [reset] see nsStyleConsts.h NS_STYLE_CONTAIN_*
uint8_t mAppearance; // [reset]
uint8_t mPosition; // [reset] see nsStyleConsts.h
uint8_t mFloats; // [reset] see nsStyleConsts.h NS_STYLE_FLOAT_*
uint8_t mOriginalFloats; // [reset] saved mFloats for position:absolute/fixed;
// otherwise equal to mFloats
uint8_t mFloat; // [reset] see nsStyleConsts.h NS_STYLE_FLOAT_*
uint8_t mOriginalFloat; // [reset] saved mFloat for position:absolute/fixed;
// otherwise equal to mFloat
uint8_t mBreakType; // [reset] see nsStyleConsts.h NS_STYLE_CLEAR_*
uint8_t mBreakInside; // [reset] NS_STYLE_PAGE_BREAK_AUTO/AVOID
bool mBreakBefore; // [reset]
@ -2637,7 +2637,7 @@ struct MOZ_NEEDS_MEMMOVABLE_MEMBERS nsStyleDisplay
}
bool IsFloatingStyle() const {
return NS_STYLE_FLOAT_NONE != mFloats;
return NS_STYLE_FLOAT_NONE != mFloat;
}
bool IsAbsolutelyPositionedStyle() const {