Bug 1460781 - Add non debug build coverage build to taskcluster r=marco

MozReview-Commit-ID: H3AjJ20uspC
***
Bug 1460781 - update platform for opt build of coverage

MozReview-Commit-ID: DwX2D8KryNb
***
Bug 1460781 - fix type in buildbase

MozReview-Commit-ID: 2PsW54jtNU8
***
Bug 1460781 - incorporate changes requested from review

MozReview-Commit-ID: 5hm6HAncogh

--HG--
rename : testing/mozharness/configs/builds/releng_sub_linux_configs/64_code_coverage.py => testing/mozharness/configs/builds/releng_sub_linux_configs/64_code_coverage_debug.py
extra : rebase_source : 59f72bab7b2aa885e5a1c0313dde77e9c085f2ca

browser/config/mozconfigs/linux64/code-coverage

@@ -4,7 +4,6 @@ TOOLTOOL_DIR=${TOOLTOOL_DIR:-$topsrcdir}
 
 ac_add_options --disable-install-strip
 ac_add_options --disable-elf-hack
-ac_add_options --enable-debug
 ac_add_options --disable-sandbox
 ac_add_options --disable-profiling
 ac_add_options --enable-coverage

browser/config/mozconfigs/linux64/code-coverage-debug

@@ -0,0 +1,3 @@
+. "$topsrcdir/browser/config/mozconfigs/linux64/code-coverage"
+
+ac_add_options --enable-debug

browser/config/mozconfigs/linux64/code-coverage-opt

@@ -0,0 +1 @@
+. "$topsrcdir/browser/config/mozconfigs/linux64/code-coverage"

taskcluster/ci/build/linux.yml

@@ -858,7 +858,36 @@ linux64-ccov/debug:
             - builds/releng_base_linux_64_builds.py
         script: "mozharness/scripts/fx_desktop_build.py"
         secrets: true
-        custom-build-variant-cfg: code-coverage
+        custom-build-variant-cfg: code-coverage-debug
+        tooltool-downloads: public
+        need-xvfb: true
+    toolchains:
+        - linux64-clang-4
+        - linux64-rust
+        - linux64-gcc
+
+linux64-ccov/opt:
+    description: "Linux64-CCov Opt"
+    index:
+        product: firefox
+        job-name: linux64-ccov-opt
+    treeherder:
+        platform: linux64-ccov/opt
+        symbol: B
+        tier: 2
+    run-on-projects: []
+    worker-type: aws-provisioner-v1/gecko-{level}-b-linux
+    worker:
+        max-run-time: 36000
+    run:
+        using: mozharness
+        actions: [get-secrets build check-test update]
+        config:
+            - builds/releng_base_firefox.py
+            - builds/releng_base_linux_64_builds.py
+        script: "mozharness/scripts/fx_desktop_build.py"
+        secrets: true
+        custom-build-variant-cfg: code-coverage-opt
         tooltool-downloads: public
         need-xvfb: true
     toolchains:

testing/mozharness/configs/builds/releng_sub_linux_configs/64_code_coverage_debug.py

@@ -0,0 +1,28 @@
+import os
+
+config = {
+    'default_actions': [
+        'clobber',
+        'build',
+        'check-test',
+        'update',  # decided by query_is_nightly()
+    ],
+    'stage_platform': 'linux64-ccov',
+    #### 64 bit build specific #####
+    'env': {
+        'MOZBUILD_STATE_PATH': os.path.join(os.getcwd(), '.mozbuild'),
+        'DISPLAY': ':2',
+        'HG_SHARE_BASE_DIR': '/builds/hg-shared',
+        'MOZ_OBJDIR': '%(abs_obj_dir)s',
+        'TINDERBOX_OUTPUT': '1',
+        'TOOLTOOL_CACHE': '/builds/tooltool_cache',
+        'TOOLTOOL_HOME': '/builds',
+        'MOZ_CRASHREPORTER_NO_REPORT': '1',
+        'LC_ALL': 'C',
+        ## 64 bit specific
+        'PATH': '/usr/local/bin:/bin:\
+/usr/bin:/usr/local/sbin:/usr/sbin:/sbin',
+    },
+    'mozconfig_variant': 'code-coverage-debug',
+    #######################
+}

testing/mozharness/configs/builds/releng_sub_linux_configs/64_code_coverage_opt.py

@@ -23,6 +23,6 @@ config = {
         'PATH': '/usr/local/bin:/bin:\
 /usr/bin:/usr/local/sbin:/usr/sbin:/sbin',
     },
-    'mozconfig_variant': 'code-coverage',
+    'mozconfig_variant': 'code-coverage-opt',
     #######################
 }

testing/mozharness/mozharness/mozilla/building/buildbase.py

@@ -418,7 +418,8 @@ class BuildOptionParser(object):
         'asan-and-debug': 'builds/releng_sub_%s_configs/%s_asan_and_debug.py',
         'asan-tc-and-debug': 'builds/releng_sub_%s_configs/%s_asan_tc_and_debug.py',
         'stat-and-debug': 'builds/releng_sub_%s_configs/%s_stat_and_debug.py',
-        'code-coverage': 'builds/releng_sub_%s_configs/%s_code_coverage.py',
+        'code-coverage-debug': 'builds/releng_sub_%s_configs/%s_code_coverage_debug.py',
+        'code-coverage-opt': 'builds/releng_sub_%s_configs/%s_code_coverage_opt.py',
         'source': 'builds/releng_sub_%s_configs/%s_source.py',
         'noopt-debug': 'builds/releng_sub_%s_configs/%s_noopt_debug.py',
         'api-16-gradle-dependencies': 'builds/releng_sub_%s_configs/%s_api_16_gradle_dependencies.py',