From a361cb98b764084a49af72b8eb7e26f767b5eff0 Mon Sep 17 00:00:00 2001 From: "bzbarsky%mit.edu" Date: Mon, 5 Dec 2005 19:13:33 +0000 Subject: [PATCH] Nothing window.Components shouldn't be special for cross-domain access purposes. Bug 319079, r+sr=jst --- dom/src/base/nsDOMClassInfo.cpp | 10 ---------- dom/src/base/nsDOMClassInfo.h | 1 - modules/libpref/src/init/all.js | 1 - 3 files changed, 12 deletions(-) diff --git a/dom/src/base/nsDOMClassInfo.cpp b/dom/src/base/nsDOMClassInfo.cpp index b60ce5bb4c61..8eaf20f2bc52 100644 --- a/dom/src/base/nsDOMClassInfo.cpp +++ b/dom/src/base/nsDOMClassInfo.cpp @@ -1127,7 +1127,6 @@ jsval nsDOMClassInfo::sTop_id = JSVAL_VOID; jsval nsDOMClassInfo::sParent_id = JSVAL_VOID; jsval nsDOMClassInfo::sScrollbars_id = JSVAL_VOID; jsval nsDOMClassInfo::sLocation_id = JSVAL_VOID; -jsval nsDOMClassInfo::sComponents_id = JSVAL_VOID; jsval nsDOMClassInfo::sConstructor_id = JSVAL_VOID; jsval nsDOMClassInfo::s_content_id = JSVAL_VOID; jsval nsDOMClassInfo::sContent_id = JSVAL_VOID; @@ -1314,7 +1313,6 @@ nsDOMClassInfo::DefineStaticJSVals(JSContext *cx) SET_JSVAL_TO_STRING(sParent_id, cx, "parent"); SET_JSVAL_TO_STRING(sScrollbars_id, cx, "scrollbars"); SET_JSVAL_TO_STRING(sLocation_id, cx, "location"); - SET_JSVAL_TO_STRING(sComponents_id, cx, "Components"); SET_JSVAL_TO_STRING(sConstructor_id, cx, "constructor"); SET_JSVAL_TO_STRING(s_content_id, cx, "_content"); SET_JSVAL_TO_STRING(sContent_id, cx, "content"); @@ -3575,7 +3573,6 @@ nsDOMClassInfo::ShutDown() sParent_id = JSVAL_VOID; sScrollbars_id = JSVAL_VOID; sLocation_id = JSVAL_VOID; - sComponents_id = JSVAL_VOID; sConstructor_id = JSVAL_VOID; s_content_id = JSVAL_VOID; sContent_id = JSVAL_VOID; @@ -3741,13 +3738,6 @@ nsDOMClassInfo::doCheckPropertyAccess(JSContext *cx, JSObject *obj, jsval id, return NS_OK; } - // Don't check when getting the Components property, since we check - // its properties anyway. This will help performance. - if (id == sComponents_id && - accessMode == nsIXPCSecurityManager::ACCESS_GET_PROPERTY && isWindow) { - return NS_OK; - } - nsISupports *native = wrapper->Native(); nsCOMPtr sgo; diff --git a/dom/src/base/nsDOMClassInfo.h b/dom/src/base/nsDOMClassInfo.h index 8b490448acaf..c51e19904705 100644 --- a/dom/src/base/nsDOMClassInfo.h +++ b/dom/src/base/nsDOMClassInfo.h @@ -289,7 +289,6 @@ protected: static jsval sParent_id; static jsval sScrollbars_id; static jsval sLocation_id; - static jsval sComponents_id; static jsval sConstructor_id; static jsval s_content_id; static jsval sContent_id; diff --git a/modules/libpref/src/init/all.js b/modules/libpref/src/init/all.js index 6966e52ab04b..32173050420f 100644 --- a/modules/libpref/src/init/all.js +++ b/modules/libpref/src/init/all.js @@ -272,7 +272,6 @@ pref("capability.policy.default.Navigator.preferenceinternal.set", "UniversalPre pref("capability.policy.default.Window.blur.get", "allAccess"); pref("capability.policy.default.Window.close.get", "allAccess"); pref("capability.policy.default.Window.closed", "allAccess"); -pref("capability.policy.default.Window.Components", "allAccess"); pref("capability.policy.default.Window.document", "allAccess"); pref("capability.policy.default.Window.focus.get", "allAccess"); pref("capability.policy.default.Window.frames", "allAccess");