Bug 725380 - CrashReporter can call doFinish twice r=kats

This commit is contained in:
Mark Finkle 2012-02-08 14:23:22 -05:00
parent abd26d32f6
commit a3ab1f3918
2 changed files with 13 additions and 3 deletions

View File

@ -101,7 +101,13 @@ public class CrashReporter extends Activity
@Override
public void finish()
{
mProgressDialog.dismiss();
try {
if (mProgressDialog.isShowing()) {
mProgressDialog.dismiss();
}
} catch (Exception e) {
Log.e(LOGTAG, "exception while closing progress dialog: ", e);
}
super.finish();
}
@ -230,8 +236,10 @@ public class CrashReporter extends Activity
final CheckBox includeURLCheckbox = (CheckBox) findViewById(R.id.include_url);
String spec = extras.get("ServerURL");
if (spec == null)
if (spec == null) {
doFinish();
return;
}
Log.i("GeckoCrashReport", "server url: " + spec);
try {

View File

@ -241,8 +241,10 @@ public class CrashReporter extends Activity
final CheckBox includeURLCheckbox = (CheckBox) findViewById(R.id.include_url);
String spec = extras.get(SERVER_URL_KEY);
if (spec == null)
if (spec == null) {
doFinish();
return;
}
Log.i(LOGTAG, "server url: " + spec);
try {