Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-21 01:37:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 950444 - Make setRangeText() work for a collapsed range. r=ehsan

Browse Source
This commit is contained in:
Mats Palmgren 2013-12-17 13:30:24 +00:00
parent b7ccb49528
commit a3f84c5aa6
3 changed files with 51 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
content/html/content/src/HTMLInputElement.cpp
View File

@ -5088,7 +5088,7 @@ HTMLInputElement::SetRangeText(const nsAString& aReplacement, uint32_t aStart,
}
}
if (aStart < aEnd) {
if (aStart <= aEnd) {
value.Replace(aStart, aEnd - aStart, aReplacement);
SetValueInternal(value, false, false);
}

2
content/html/content/src/HTMLTextAreaElement.cpp
View File

@ -949,7 +949,7 @@ HTMLTextAreaElement::SetRangeText(const nsAString& aReplacement,
}
}
if (aStart < aEnd) {
if (aStart <= aEnd) {
value.Replace(aStart, aEnd - aStart, aReplacement);
SetValueInternal(value, false);
}

54
content/html/content/test/forms/test_set_range_text.html
View File

@ -90,15 +90,59 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=850364
ok(false, "input event should NOT be fired for " + + aEvent.target.id);
}, false);
//test setRange(replacement)
var test = " setRange(replacement), shrink";
elem.value = "0123456789ABCDEF";
elem.setSelectionRange(1, 6);
elem.setRangeText("xyz");
is(elem.value, "0xyz6789ABCDEF", msg + ".value == \"0xyz6789ABCDEF\"");
is(elem.selectionStart, 1, msg + ".selectionStart == 1");
is(elem.selectionEnd, 4, msg + ".selectionEnd == 4");
is(elem.value, "0xyz6789ABCDEF", msg + test);
is(elem.selectionStart, 1, msg + test);
is(elem.selectionEnd, 4, msg + test);
elem.setRangeText("mnk");
is(elem.value, "0mnk6789ABCDEF", msg + ".value == \"0mnk6789ABCDEF\"");
is(elem.value, "0mnk6789ABCDEF", msg + test);
expectedNumOfSelectCalls += 2;
test = " setRange(replacement), expand";
elem.value = "0123456789ABCDEF";
elem.setSelectionRange(1, 2);
elem.setRangeText("xyz");
is(elem.value, "0xyz23456789ABCDEF", msg + test);
is(elem.selectionStart, 1, msg + test);
is(elem.selectionEnd, 4, msg + test);
elem.setRangeText("mnk");
is(elem.value, "0mnk23456789ABCDEF", msg + test);
expectedNumOfSelectCalls += 2;
test = " setRange(replacement) pure insertion at start";
elem.value = "0123456789ABCDEF";
elem.setSelectionRange(0, 0);
elem.setRangeText("xyz");
is(elem.value, "xyz0123456789ABCDEF", msg + test);
is(elem.selectionStart, 0, msg + test);
is(elem.selectionEnd, 0, msg + test);
elem.setRangeText("mnk");
is(elem.value, "mnkxyz0123456789ABCDEF", msg + test);
expectedNumOfSelectCalls += 2;
test = " setRange(replacement) pure insertion in the middle";
elem.value = "0123456789ABCDEF";
elem.setSelectionRange(4, 4);
elem.setRangeText("xyz");
is(elem.value, "0123xyz456789ABCDEF", msg + test);
is(elem.selectionStart, 4, msg + test);
is(elem.selectionEnd, 4, msg + test);
elem.setRangeText("mnk");
is(elem.value, "0123mnkxyz456789ABCDEF", msg + test);
expectedNumOfSelectCalls += 2;
test = " setRange(replacement) pure insertion at the end";
elem.value = "0123456789ABCDEF";
elem.setSelectionRange(16, 16);
elem.setRangeText("xyz");
is(elem.value, "0123456789ABCDEFxyz", msg + test);
is(elem.selectionStart, 16, msg + test);
is(elem.selectionEnd, 16, msg + test);
elem.setRangeText("mnk");
is(elem.value, "0123456789ABCDEFmnkxyz", msg + test);
expectedNumOfSelectCalls += 2;
//test SetRange(replacement, start, end, mode) with start > end