Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 12:51:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1820654 - Replace the label link under manualUpdate with html element. r=tgiles,flod,application-update-reviewers,bytesized

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D175011
This commit is contained in:
anayo 2023-04-18 16:01:17 +00:00
parent 8ef888bfb2
commit a40aadc4ef
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
browser/components/preferences/main.inc.xhtml
View File

@ -562,8 +562,8 @@
disabled="true"/>
</hbox>
<hbox id="manualUpdate" align="start">
<description class="face-sad" flex="1" data-l10n-id="update-manual">
<label class="manualLink" data-l10n-name="manual-link" is="text-link"/>
<description class="face-sad" data-l10n-id="aboutdialog-update-manual">
<html:a class="manualLink" data-l10n-name="manual-link" target="_blank"/>
</description>
<button data-l10n-id="update-checkForUpdatesButton"
is="highlightable-button"

2
browser/locales/en-US/browser/aboutDialog.ftl
View File

@ -29,7 +29,7 @@ update-noUpdatesFound = { -brand-short-name } is up to date
aboutdialog-update-checking-failed = Failed to check for updates.
update-otherInstanceHandlingUpdates = { -brand-short-name } is being updated by another instance
update-manual = Updates available at <label data-l10n-name="manual-link"/>
aboutdialog-update-manual = Updates available at <a data-l10n-name="manual-link"/>
update-unsupported = You can not perform further updates on this system. <label data-l10n-name="unsupported-link">Learn more</label>

6
toolkit/mozapps/update/tests/browser/head.js
View File

@ -1116,6 +1116,12 @@ function runAboutPrefsUpdateTest(params, steps) {
if (selectedPanel.id == "downloadFailed") {
selector = "a.text-link";
}
// The manualUpdate panel in about:preferences uses
// the moz-support-link element which doesn't have
// the .text-link class.
if (selectedPanel.id == "manualUpdate") {
selector = "a.manualLink";
}
let link = selectedPanel.querySelector(selector);
is(
link.href,