Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-19 08:15:31 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1622856 - Disable new pass manager on Mac hosts r=firefox-build-system-reviewers,rstewart

Browse Source 
Several developers have reported hangs on native Mac builds. I think we should disable the flag on Mac hosts. Even if we could fix the current hangs, without coverage in CI for this build configuration, we're asking for more trouble down the road.

Differential Revision: https://phabricator.services.mozilla.com/D67007

--HG--
extra : moz-landing-system : lando
This commit is contained in:
David Major 2020-03-16 17:57:41 +00:00
parent 52ebda3e05
commit a453b0920c
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
build/moz.configure/flags.configure
View File

@ -31,13 +31,12 @@ set_config('MOZ_RUST_DEFAULT_FLAGS', rust_flags)
js_option('--disable-new-pass-manager',
help='Use the legacy LLVM pass manager in clang builds')
@depends('--enable-new-pass-manager', c_compiler, host, mozbuild_state_path)
def new_pass_manager_flags(enabled, compiler, host, mozbuild_state_path):
@depends('--enable-new-pass-manager', c_compiler, host)
def new_pass_manager_flags(enabled, compiler, host):
if host.os == 'OSX':
# If we're using Xcode's clang, we can't trust its version number
mozbuild_clang_dir = os.path.join(mozbuild_state_path, 'clang', 'bin')
if os.path.dirname(compiler.compiler) != mozbuild_clang_dir:
return None
# Some native Mac builds hang with the new pass manager. Given the
# inability to test in CI, don't take the risk of further breakage.
return None
if enabled and compiler.version >= '9.0.0':
if compiler.type == 'clang':
return ['-fexperimental-new-pass-manager']