From a4e53cd5766e675c648b5af27ccce7fa29269dad Mon Sep 17 00:00:00 2001 From: johnkeis Date: Tue, 4 Feb 2003 09:59:10 +0000 Subject: [PATCH] Support min_row_size, max_row_size params (helps for debugging) --- webtools/tinderbox3/scripts/Tinderbox3/ShowBuilds.pm | 7 +++++-- webtools/tinderbox3/scripts/showbuilds.pl | 6 ++++-- webtools/tinderbox3/server/Tinderbox3/ShowBuilds.pm | 7 +++++-- webtools/tinderbox3/server/showbuilds.pl | 6 ++++-- 4 files changed, 18 insertions(+), 8 deletions(-) diff --git a/webtools/tinderbox3/scripts/Tinderbox3/ShowBuilds.pm b/webtools/tinderbox3/scripts/Tinderbox3/ShowBuilds.pm index 18113a009140..c4d23f901db2 100755 --- a/webtools/tinderbox3/scripts/Tinderbox3/ShowBuilds.pm +++ b/webtools/tinderbox3/scripts/Tinderbox3/ShowBuilds.pm @@ -8,7 +8,8 @@ use Tinderbox3::BonsaiColumns; use Tinderbox3::BuildTimeColumn; sub print_showbuilds { - my ($p, $dbh, $fh, $tree, $start_time, $end_time) = @_; + my ($p, $dbh, $fh, $tree, $start_time, $end_time, + $min_row_size, $max_row_size) = @_; # # Get tree and patch info @@ -19,7 +20,9 @@ sub print_showbuilds { } my ($field_short_names, $field_processors_str, $header, $footer, $special_message, $sheriff, $build_engineer, $cvs_co_date, $status, - $min_row_size, $max_row_size) = @{$tree_info}; + $default_min_row_size, $default_max_row_size) = @{$tree_info}; + $min_row_size = $default_min_row_size if !defined($min_row_size); + $max_row_size = $default_max_row_size if !defined($max_row_size); my %field_processors; # Create the handlers for the different fields require Tinderbox3::FieldProcessors::default; diff --git a/webtools/tinderbox3/scripts/showbuilds.pl b/webtools/tinderbox3/scripts/showbuilds.pl index 820604d30412..0b40a6dc0598 100755 --- a/webtools/tinderbox3/scripts/showbuilds.pl +++ b/webtools/tinderbox3/scripts/showbuilds.pl @@ -9,7 +9,6 @@ my $p = new CGI; my $dbh = get_dbh(); my $tree = $p->param('tree') || ""; -# XXX These will get set by parameters eventually my ($start_time, $end_time); if ($p->param('start_time')) { $start_time = $p->param('start_time'); @@ -25,8 +24,11 @@ if ($p->param('start_time')) { $start_time = $end_time - 24*60*60; } +my $min_row_size = $p->param('min_row_size'); +my $max_row_size = $p->param('max_row_size'); + print $p->header; Tinderbox3::ShowBuilds::print_showbuilds($p, $dbh, *STDOUT, $tree, $start_time, - $end_time); + $end_time, $min_row_size, $max_row_size); $dbh->disconnect; diff --git a/webtools/tinderbox3/server/Tinderbox3/ShowBuilds.pm b/webtools/tinderbox3/server/Tinderbox3/ShowBuilds.pm index 18113a009140..c4d23f901db2 100755 --- a/webtools/tinderbox3/server/Tinderbox3/ShowBuilds.pm +++ b/webtools/tinderbox3/server/Tinderbox3/ShowBuilds.pm @@ -8,7 +8,8 @@ use Tinderbox3::BonsaiColumns; use Tinderbox3::BuildTimeColumn; sub print_showbuilds { - my ($p, $dbh, $fh, $tree, $start_time, $end_time) = @_; + my ($p, $dbh, $fh, $tree, $start_time, $end_time, + $min_row_size, $max_row_size) = @_; # # Get tree and patch info @@ -19,7 +20,9 @@ sub print_showbuilds { } my ($field_short_names, $field_processors_str, $header, $footer, $special_message, $sheriff, $build_engineer, $cvs_co_date, $status, - $min_row_size, $max_row_size) = @{$tree_info}; + $default_min_row_size, $default_max_row_size) = @{$tree_info}; + $min_row_size = $default_min_row_size if !defined($min_row_size); + $max_row_size = $default_max_row_size if !defined($max_row_size); my %field_processors; # Create the handlers for the different fields require Tinderbox3::FieldProcessors::default; diff --git a/webtools/tinderbox3/server/showbuilds.pl b/webtools/tinderbox3/server/showbuilds.pl index 820604d30412..0b40a6dc0598 100755 --- a/webtools/tinderbox3/server/showbuilds.pl +++ b/webtools/tinderbox3/server/showbuilds.pl @@ -9,7 +9,6 @@ my $p = new CGI; my $dbh = get_dbh(); my $tree = $p->param('tree') || ""; -# XXX These will get set by parameters eventually my ($start_time, $end_time); if ($p->param('start_time')) { $start_time = $p->param('start_time'); @@ -25,8 +24,11 @@ if ($p->param('start_time')) { $start_time = $end_time - 24*60*60; } +my $min_row_size = $p->param('min_row_size'); +my $max_row_size = $p->param('max_row_size'); + print $p->header; Tinderbox3::ShowBuilds::print_showbuilds($p, $dbh, *STDOUT, $tree, $start_time, - $end_time); + $end_time, $min_row_size, $max_row_size); $dbh->disconnect;