Bug 1219183 - Update comments that reference renamed thisObject hook r=shu

This commit is contained in:
Jon Coppeard 2015-10-30 09:50:06 +00:00
parent caef857d16
commit a6103d6c93
8 changed files with 10 additions and 11 deletions

View File

@ -743,7 +743,7 @@ class CGInterfaceObjectJSClass(CGThing):
nullptr, /* unwatch */
nullptr, /* getElements */
nullptr, /* enumerate */
nullptr, /* thisObject */
nullptr, /* thisValue */
InterfaceObjectToString, /* funToString */
}
},

View File

@ -773,7 +773,7 @@ struct Class
* describe their properties and layout. Classes using this flag must
* provide their own property behavior, either by being proxy classes (do
* this) or by overriding all the ObjectOps except getElements, watch,
* unwatch, and thisObject (don't do this).
* unwatch, and thisValue (don't do this).
*/
static const uint32_t NON_NATIVE = JSCLASS_INTERNAL_FLAG2;

View File

@ -2265,7 +2265,7 @@ OutlineTransparentTypedObject::getOrCreateBuffer(JSContext* cx)
nullptr, nullptr, /* watch/unwatch */ \
nullptr, /* getElements */ \
TypedObject::obj_enumerate, \
nullptr, /* thisObject */ \
nullptr, /* thisValue */ \
} \
}

View File

@ -6740,8 +6740,7 @@ class MComputeThis
return true;
}
// Note: don't override getAliasSet: the thisObject hook can be
// effectful.
// Note: don't override getAliasSet: the thisValue hook can be effectful.
};
// Load an arrow function's |this| value.

View File

@ -353,7 +353,7 @@ namespace js {
js::proxy_Watch, js::proxy_Unwatch, \
js::proxy_GetElements, \
nullptr, /* enumerate */ \
nullptr, /* thisObject */ \
nullptr, /* thisValue */ \
js::proxy_FunToString, \
} \
}

View File

@ -6774,8 +6774,8 @@ DebuggerGenericEval(JSContext* cx, const char* fullMethodName, const Value& code
} else {
/*
* Use the global lexical scope as 'this'. If the global is an inner
* object, it should have a thisObject hook that returns the
* appropriate outer object.
* object, it should have a thisValue hook that returns the appropriate
* outer object.
*/
if (!GetThisValue(cx, scope, &thisv))
return false;

View File

@ -524,7 +524,7 @@ js::Invoke(JSContext* cx, const Value& thisv, const Value& fval, unsigned argc,
if (args.thisv().isObject()) {
/*
* We must call the thisObject hook in case we are not called from the
* We must call the thisValue hook in case we are not called from the
* interpreter, where a prior bytecode has computed an appropriate
* |this| already. But don't do that if fval is a DOM function.
*/

View File

@ -940,7 +940,7 @@ const Class UnboxedPlainObject::class_ = {
nullptr, /* No unwatch needed, as watch() converts the object to native */
nullptr, /* getElements */
UnboxedPlainObject::obj_enumerate,
nullptr, /* thisObject */
nullptr, /* thisValue */
}
};
@ -1631,7 +1631,7 @@ const Class UnboxedArrayObject::class_ = {
nullptr, /* No unwatch needed, as watch() converts the object to native */
nullptr, /* getElements */
UnboxedArrayObject::obj_enumerate,
nullptr, /* thisObject */
nullptr, /* thisValue */
}
};