Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-23 10:54:33 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 943734 - escape URL arguments in mochitests for the benefit of LLDB; r=jmaher

Browse Source
This commit is contained in:
Nathan Froyd 2013-12-03 13:01:30 -05:00
parent d77b910df1
commit a61847de44
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
build/automationutils.py
View File

@ -67,7 +67,8 @@ DEBUGGER_INFO = {
"lldb": {
"interactive": True,
"args": "--"
"args": "--",
"requiresEscapedArgs": True
},
# valgrind doesn't explain much about leaks unless you set the
@ -211,7 +212,8 @@ def getDebuggerInfo(directory, debugger, debuggerArgs, debuggerInteractive = Fal
debuggerInfo = {
"path": debuggerPath,
"interactive" : getDebuggerInfo("interactive", False),
"args": getDebuggerInfo("args", "").split()
"args": getDebuggerInfo("args", "").split(),
"requiresEscapedArgs": getDebuggerInfo("requiresEscapedArgs", False)
}
if debuggerArgs:

4
testing/mochitest/runtests.py
View File

@ -835,7 +835,9 @@ class Mochitest(MochitestUtilsMixin):
# https://bugzilla.mozilla.org/show_bug.cgi?id=916512
args.append('-foreground')
if testUrl:
args.append(testUrl)
if debuggerInfo and debuggerInfo['requiresEscapedArgs']:
testUrl = testUrl.replace("&", "\\&")
args.append(testUrl)
if mozinfo.info["debug"] and not webapprtChrome:
shutdownLeaks = ShutdownLeaks(log.info)