Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-30 08:12:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1923953 - Be more specific in 'deprecation' notices for no-op'd browser.telemetry.* APIs r=willdurand DONTBUILD

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D225274
This commit is contained in:
Chris H-C 2024-10-11 14:30:22 +00:00
parent 63b023c45f
commit a6f5ab5060
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
toolkit/components/extensions/schemas/telemetry.json
View File

@ -286,7 +286,7 @@
},
{
"name": "recordEvent",
"deprecated": "`recordEvent` has been deprecated since Firefox 132 (see bug 1894533)",
"deprecated": "`recordEvent` is a no-op since Firefox 132 (see bug 1894533)",
"type": "function",
"description": "Record an event in Telemetry. Throws when trying to record an unknown event.",
"async": true,
@ -343,7 +343,7 @@
},
{
"name": "registerEvents",
"deprecated": "`registerEvents` has been deprecated since Firefox 132 (see bug 1894533)",
"deprecated": "`registerEvents` is a no-op since Firefox 132 (see bug 1894533)",
"type": "function",
"description": "Register new events to record them from addons. See nsITelemetry.idl for more details.",
"async": true,
@ -363,7 +363,7 @@
},
{
"name": "setEventRecordingEnabled",
"deprecated": "`setEventRecordingEnabled` has been deprecated since Firefox 133 (see bug 1920562)",
"deprecated": "`setEventRecordingEnabled` is a no-op since Firefox 133 (see bug 1920562)",
"type": "function",
"description": "Enable recording of events in a category. Events default to recording enabled. This allows to toggle recording for all events in the specified category.",
"async": true,

4
toolkit/components/extensions/test/xpcshell/test_ext_telemetry.js
View File

@ -769,9 +769,9 @@ if (AppConstants.MOZ_BUILD_APP === "browser") {
});
const expectedRegisterEventsMessage =
/`registerEvents` has been deprecated since Firefox 132 \(see bug 1894533\)/;
/`registerEvents` is a no-op since Firefox 132 \(see bug 1894533\)/;
const expectedRecordEventMessage =
/`recordEvent` has been deprecated since Firefox 132 \(see bug 1894533\)/;
/`recordEvent` is a no-op since Firefox 132 \(see bug 1894533\)/;
AddonTestUtils.checkMessages(messages, {
expected: [

6
toolkit/components/telemetry/docs/collection/webextension-api.rst
View File

@ -109,7 +109,7 @@ Sets the scalar to the maximum of the current and the passed value
``recordEvent``
~~~~~~~~~~~~~~~
Deprecated since Firefox 132 by bug 1894533.
As of Firefox 132, this method is a no-op. See Bug 1894533.
Instead, use :doc:`Glean APIs <../../glean/user/glean_for_legacy_events>` to record events.
@ -128,13 +128,13 @@ Register new scalars to record them from addons. See :ref:`registerscalars` for
``registerEvents``
~~~~~~~~~~~~~~~~~~
Deprecated since Firefox 132 by bug 1894533.
As of Firefox 132, this method is a no-op. See Bug 1894533.
Instead, use :doc:`Glean event definitions <../../glean/user/glean_for_legacy_events>` for your extension's events.
``setEventRecordingEnabled``
~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Deprecated since Firefox 133 by bug 1920562.
As of Firefox 133, this method is a no-op. Event recording is enabled by default unconditionally. See Bug 1920562.
Instead, use :doc:`Glean event definitions <../../glean/user/glean_for_legacy_events>` for your extension's events.