fix for bug #402668: reduce Ts by initially hiding editBookmarkPanel and autocomplete panel. r=gavin, a=schrep

This commit is contained in:
sspitzer@mozilla.org 2007-11-09 17:43:14 -08:00
parent aa16c6429e
commit a7970f33e9
4 changed files with 29 additions and 2 deletions

View File

@ -52,6 +52,9 @@ var PlacesCommandHook = {
get panel() { get panel() {
delete this.panel; delete this.panel;
var element = document.getElementById("editBookmarkPanel"); var element = document.getElementById("editBookmarkPanel");
// initially the panel is hidden
// to avoid impacting startup / new window performance
element.hidden = false;
element.addEventListener("popuphiding", this, false); element.addEventListener("popuphiding", this, false);
element.addEventListener("keypress", this, true); element.addEventListener("keypress", this, true);
return this.panel = element; return this.panel = element;

View File

@ -99,9 +99,9 @@
onclick="checkForMiddleClick(this, event);"/> onclick="checkForMiddleClick(this, event);"/>
<tooltip id="aHTMLTooltip" onpopupshowing="return FillInHTMLTooltip(document.tooltipNode);"/> <tooltip id="aHTMLTooltip" onpopupshowing="return FillInHTMLTooltip(document.tooltipNode);"/>
<panel type="autocomplete" chromedir="&locale.dir;" id="PopupAutoComplete" noautofocus="true"/> <panel type="autocomplete" chromedir="&locale.dir;" id="PopupAutoComplete" noautofocus="true" hidden="true"/>
<panel id="editBookmarkPanel" orient="vertical"> <panel id="editBookmarkPanel" orient="vertical" hidden="true">
<vbox id="editBookmarkPanelContent" flex="1"/> <vbox id="editBookmarkPanelContent" flex="1"/>
<hbox flex="1"> <hbox flex="1">
<spacer flex="1"/> <spacer flex="1"/>

View File

@ -221,6 +221,19 @@
<binding id="urlbar-result-popup" extends="chrome://global/content/bindings/autocomplete.xml#autocomplete-result-popup"> <binding id="urlbar-result-popup" extends="chrome://global/content/bindings/autocomplete.xml#autocomplete-result-popup">
<implementation> <implementation>
<method name="openAutocompletePopup">
<parameter name="aInput"/>
<parameter name="aElement"/>
<body><![CDATA[
// initially the panel is hidden
// to avoid impacting startup / new window performance
aInput.popup.hidden = false;
// this method is defined on the base binding
this._openAutocompletePopup(aInput, aElement);
]]></body>
</method>
<method name="onPopupClick"> <method name="onPopupClick">
<parameter name="aEvent"/> <parameter name="aEvent"/>
<body><![CDATA[ <body><![CDATA[

View File

@ -570,6 +570,17 @@
onget="return this.mPopupOpen;"/> onget="return this.mPopupOpen;"/>
<method name="openAutocompletePopup"> <method name="openAutocompletePopup">
<parameter name="aInput"/>
<parameter name="aElement"/>
<body><![CDATA[
// until we have "baseBinding", (see bug #373652) this allows
// us to override openAutocompletePopup(), but still call
// the method on the base class
this._openAutocompletePopup(aInput, aElement);
]]></body>
</method>
<method name="_openAutocompletePopup">
<parameter name="aInput"/> <parameter name="aInput"/>
<parameter name="aElement"/> <parameter name="aElement"/>
<body><![CDATA[ <body><![CDATA[