Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1270076 - Make CallArgs's JS_DEBUG-only handling of asserting proper rval()/calleev() sequencing work without using enumerated types, for Servo bindings. r=nox/r=jwalden tag-team effort

Browse Source
This commit is contained in:
Jeff Walden 2016-06-07 16:55:49 -07:00
parent 6227e6e115
commit a7cb086da3
1 changed files with 14 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
js/public/CallArgs.h
View File

@ -95,23 +95,22 @@ extern JS_PUBLIC_API(void)
CheckIsValidConstructible(Value v);
#endif
enum UsedRval { IncludeUsedRval, NoUsedRval };
template<UsedRval WantUsedRval>
class MOZ_STACK_CLASS UsedRvalBase;
template<>
class MOZ_STACK_CLASS UsedRvalBase<IncludeUsedRval>
class MOZ_STACK_CLASS IncludeUsedRval
{
protected:
#ifdef JS_DEBUG
mutable bool usedRval_;
void setUsedRval() const { usedRval_ = true; }
void clearUsedRval() const { usedRval_ = false; }
void assertUnusedRval() const { MOZ_ASSERT(!usedRval_); }
#else
void setUsedRval() const {}
void clearUsedRval() const {}
void assertUnusedRval() const {}
#endif
};
template<>
class MOZ_STACK_CLASS UsedRvalBase<NoUsedRval>
class MOZ_STACK_CLASS NoUsedRval
{
protected:
void setUsedRval() const {}
@ -119,16 +118,13 @@ class MOZ_STACK_CLASS UsedRvalBase<NoUsedRval>
void assertUnusedRval() const {}
};
template<UsedRval WantUsedRval>
class MOZ_STACK_CLASS CallArgsBase
: public UsedRvalBase<
#ifdef JS_DEBUG
WantUsedRval
#else
NoUsedRval
#endif
>
template<class WantUsedRval>
class MOZ_STACK_CLASS CallArgsBase : public WantUsedRval
{
static_assert(mozilla::IsSame<WantUsedRval, IncludeUsedRval>::value ||
mozilla::IsSame<WantUsedRval, NoUsedRval>::value,
"WantUsedRval can only be IncludeUsedRval or NoUsedRval");
protected:
Value* argv_;
unsigned argc_;