Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-12-04 02:57:38 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1856514 - Make sure nsRefreshDriver will tick enough times for user input handling r=smaug

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D190108
This commit is contained in:
Sean Feng 2023-10-11 19:39:37 +00:00
parent 0cc423b3e3
commit a8185359ae
6 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dom/base/test/browser.toml
View File

@ -142,4 +142,6 @@ skip-if = ["verify"]
["browser_user_input_handling_delay_bfcache.js"]
["browser_user_input_handling_delay_reload_ticks.js"]
["browser_xml_toggle.js"]

54
dom/base/test/browser_user_input_handling_delay_reload_ticks.js Normal file
View File

@ -0,0 +1,54 @@
/* -*- Mode: JavaScript; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
async function test_user_input_handling_delay_helper(prefs) {
await SpecialPowers.pushPrefEnv({
set: prefs,
});
const tab = await BrowserTestUtils.openNewForegroundTab(
gBrowser,
`data:text/html,<body></body>`
);
await BrowserTestUtils.reloadTab(tab);
// eslint-disable-next-line mozilla/no-arbitrary-setTimeout
await new Promise(r => setTimeout(r, 5000));
const userInputHappend = SpecialPowers.spawn(
tab.linkedBrowser,
[],
async function () {
await ContentTaskUtils.waitForEvent(content, "keydown");
}
).then(function () {
Assert.ok(
true,
"User input event should be able to work after 5 seconds of an reload"
);
});
// In the buggy build, the following tab key doesn't work
await BrowserTestUtils.synthesizeKey("KEY_Tab", {}, tab.linkedBrowser);
await BrowserTestUtils.synthesizeKey("KEY_Tab", {}, tab.linkedBrowser);
await BrowserTestUtils.synthesizeKey("KEY_Tab", {}, tab.linkedBrowser);
await BrowserTestUtils.synthesizeKey("KEY_Tab", {}, tab.linkedBrowser);
await userInputHappend;
BrowserTestUtils.removeTab(tab);
}
add_task(async function test_MinTick() {
const prefs = [
["dom.input_events.security.minNumTicks", 10],
["dom.input_events.security.minTimeElapsedInMS", 0],
["dom.input_events.security.isUserInputHandlingDelayTest", true],
];
await test_user_input_handling_delay_helper(prefs);
});

7
layout/base/nsPresContext.cpp
View File

@ -1288,6 +1288,13 @@ void nsPresContext::MaybeIncreaseMeasuredTicksSinceLoading() {
}
}
}
bool nsPresContext::NeedsMoreTicksForUserInput() const {
MOZ_ASSERT(IsRoot());
return mMeasuredTicksSinceLoading <
StaticPrefs::dom_input_events_security_minNumTicks();
}
// Helper function for setting Anim Mode on image
static void SetImgAnimModeOnImgReq(imgIRequest* aImgReq, uint16_t aMode) {
if (aImgReq) {

2
layout/base/nsPresContext.h
View File

@ -516,6 +516,8 @@ class nsPresContext : public nsISupports, public mozilla::SupportsWeakPtr {
void MaybeIncreaseMeasuredTicksSinceLoading();
bool NeedsMoreTicksForUserInput() const;
void ResetUserInputEventsAllowed() {
MOZ_ASSERT(IsRoot());
mMeasuredTicksSinceLoading = 0;

7
layout/base/nsRefreshDriver.cpp
View File

@ -1976,6 +1976,10 @@ auto nsRefreshDriver::GetReasonsToTick() const -> TickReasons {
if (!mVisualViewportScrollEvents.IsEmpty()) {
reasons |= TickReasons::eHasVisualViewportScrollEvents;
}
if (mPresContext && mPresContext->IsRoot() &&
mPresContext->NeedsMoreTicksForUserInput()) {
reasons |= TickReasons::eRootNeedsMoreTicksForUserInput;
}
return reasons;
}
@ -2015,6 +2019,9 @@ void nsRefreshDriver::AppendTickReasonsToString(TickReasons aReasons,
if (aReasons & TickReasons::eHasVisualViewportScrollEvents) {
aStr.AppendLiteral(" HasVisualViewportScrollEvents");
}
if (aReasons & TickReasons::eRootNeedsMoreTicksForUserInput) {
aStr.AppendLiteral(" RootNeedsMoreTicksForUserInput");
}
}
bool nsRefreshDriver::

1
layout/base/nsRefreshDriver.h
View File

@ -452,6 +452,7 @@ class nsRefreshDriver final : public mozilla::layers::TransactionIdAllocator,
eHasVisualViewportScrollEvents = 1 << 6,
eHasPendingMediaQueryListeners = 1 << 7,
eNeedsToNotifyResizeObservers = 1 << 8,
eRootNeedsMoreTicksForUserInput = 1 << 9,
};
void AddForceNotifyContentfulPaintPresContext(nsPresContext* aPresContext);