Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-29 07:42:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1259812: Fix tests to account for change in tooltip text and breadcrumb lifecycle;r=pbro

Browse Source 
MozReview-Commit-ID: 6KJOAhhgmkX
This commit is contained in:
Steve Melia 2016-05-29 22:58:32 +01:00
parent be63605b00
commit a847380c46
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
devtools/client/inspector/breadcrumbs.js
View File

@ -753,8 +753,10 @@ HTMLBreadcrumbs.prototype = {
*/
scroll: function () {
// FIXME bug 684352: make sure its immediate neighbors are visible too.
let element = this.nodeHierarchy[this.currentIndex].button;
element.scrollIntoView({ block: "end", behavior: "smooth" });
if (!this.isDestroyed) {
let element = this.nodeHierarchy[this.currentIndex].button;
element.scrollIntoView({ block: "end", behavior: "smooth" });
}
},
/**

2
devtools/client/inspector/test/browser_inspector_breadcrumbs_namespaced.js
View File

@ -49,7 +49,7 @@ add_task(function* () {
is(labelTag.textContent, node.nodeName,
"Node " + node.selector + " has the expected tag name");
is(checkedButton.getAttribute("tooltiptext"), node.title,
is(checkedButton.getAttribute("title"), node.title,
"Node " + node.selector + " has the expected tooltip");
}
});

2
devtools/client/inspector/test/browser_inspector_initialization.js
View File

@ -108,6 +108,6 @@ function* testBreadcrumbs(selector, inspector) {
let expectedText = b.prettyPrintNodeAsText(nodeFront);
let button = b.container.querySelector("button[checked=true]");
ok(button, "A crumbs is checked=true");
is(button.getAttribute("tooltiptext"), expectedText,
is(button.getAttribute("title"), expectedText,
"Crumb refers to the right node");
}