mirror of
https://github.com/mozilla/gecko-dev.git
synced 2024-10-17 15:25:52 +00:00
Bug 1259812: Fix tests to account for change in tooltip text and breadcrumb lifecycle;r=pbro
MozReview-Commit-ID: 6KJOAhhgmkX
This commit is contained in:
parent
be63605b00
commit
a847380c46
@ -753,8 +753,10 @@ HTMLBreadcrumbs.prototype = {
|
|||||||
*/
|
*/
|
||||||
scroll: function () {
|
scroll: function () {
|
||||||
// FIXME bug 684352: make sure its immediate neighbors are visible too.
|
// FIXME bug 684352: make sure its immediate neighbors are visible too.
|
||||||
let element = this.nodeHierarchy[this.currentIndex].button;
|
if (!this.isDestroyed) {
|
||||||
element.scrollIntoView({ block: "end", behavior: "smooth" });
|
let element = this.nodeHierarchy[this.currentIndex].button;
|
||||||
|
element.scrollIntoView({ block: "end", behavior: "smooth" });
|
||||||
|
}
|
||||||
},
|
},
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -49,7 +49,7 @@ add_task(function* () {
|
|||||||
is(labelTag.textContent, node.nodeName,
|
is(labelTag.textContent, node.nodeName,
|
||||||
"Node " + node.selector + " has the expected tag name");
|
"Node " + node.selector + " has the expected tag name");
|
||||||
|
|
||||||
is(checkedButton.getAttribute("tooltiptext"), node.title,
|
is(checkedButton.getAttribute("title"), node.title,
|
||||||
"Node " + node.selector + " has the expected tooltip");
|
"Node " + node.selector + " has the expected tooltip");
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
@ -108,6 +108,6 @@ function* testBreadcrumbs(selector, inspector) {
|
|||||||
let expectedText = b.prettyPrintNodeAsText(nodeFront);
|
let expectedText = b.prettyPrintNodeAsText(nodeFront);
|
||||||
let button = b.container.querySelector("button[checked=true]");
|
let button = b.container.querySelector("button[checked=true]");
|
||||||
ok(button, "A crumbs is checked=true");
|
ok(button, "A crumbs is checked=true");
|
||||||
is(button.getAttribute("tooltiptext"), expectedText,
|
is(button.getAttribute("title"), expectedText,
|
||||||
"Crumb refers to the right node");
|
"Crumb refers to the right node");
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user