Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-09 03:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1779989 - Explicitly disallow ES modules in ESLint import-globals-from statements. r=arai

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D152002
This commit is contained in:
Mark Banner 2022-07-19 05:57:15 +00:00
parent f724fd0ca0
commit a869ce033b
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/code-quality/lint/linters/eslint-plugin-mozilla/import-globals-from.rst
View File

@ -12,3 +12,7 @@ on each other's globals.
If <path> is a relative path, then it must be relative to the file being
checked by the rule.
Note: ``import-globals-from`` does not support loading globals from ES modules.
These should be imported as variable definitions directly, or the file where
they are imported should be referenced.

19
tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js
View File

@ -81,8 +81,9 @@ var lastHTMLGlobals = {};
* @param {String} filePath
* The absolute path of the file being parsed.
*/
function GlobalsForNode(filePath) {
function GlobalsForNode(filePath, context) {
this.path = filePath;
this.context = context;
if (this.path) {
this.dirname = path.dirname(this.path);
@ -128,6 +129,22 @@ GlobalsForNode.prototype = {
let filePath = match[1].trim();
if (filePath.endsWith(".mjs")) {
if (this.context) {
this.context.report(
comment,
"import-globals-from does not support module files - use a direct import instead"
);
} else {
// Fall back to throwing an error, as we do not have a context in all situations,
// e.g. when loading the environment.
throw new Error(
"import-globals-from does not support module files - use a direct import instead"
);
}
continue;
}
if (!path.isAbsolute(filePath)) {
filePath = path.resolve(this.dirname, filePath);
} else {