Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-02-04 13:07:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add missing rooting around a call out JS_Enumerate. bug 343290, r=brendan

Browse Source
This commit is contained in:
mrbkap%gmail.com 2006-07-02 03:30:46 +00:00
parent 21bc46e129
commit a91848d680
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
js/src/jsapi.c
View File

@ -3388,8 +3388,17 @@ JS_NewPropertyIterator(JSContext *cx, JSObject *obj)
pdata = (scope->object == obj) ? scope->lastProp : NULL;
index = -1;
} else {
/* Non-native case: enumerate a JSIdArray and keep it via private. */
JSTempValueRooter tvr;
/*
* Non-native case: enumerate a JSIdArray and keep it via private.
*
* Note: we have to make sure that we root obj around the call to
* JS_Enumerate to protect against multiple allocations under it.
*/
JS_PUSH_SINGLE_TEMP_ROOT(cx, OBJECT_TO_JSVAL(obj), &tvr);
ida = JS_Enumerate(cx, obj);
JS_POP_TEMP_ROOT(cx, &tvr);
if (!ida)
goto bad;
pdata = ida;