Bug 1577258 - Explicitly flush layout in an a11y test. r=eeejay

We have an optimization to avoid an expensive reflow from SetFullZoom, see
mSuppressResizeReflow[1].

That was done because we used to do a full synchronous reflow right after. We no
longer do that, but due to that member we also don't invalidate!

My second patch in this bug changes the behavior of that flag so that we don't
synchronously reflow, but we do invalidate. So in turn this test before the
change wasn't really testing the zoomed code-path since it was using the clean
layout from before the zoom operation.

a11y getBounds and co. don't flush layout (they probably should), but since with
my patch we dirty the frame tree, and dirty frames return bogus offsets, the
test starts failing.

Flush layout explicitly to ensure we're testing the zoomed code path.

[1]: https://searchfox.org/mozilla-central/rev/325c1a707819602feff736f129cb36055ba6d94f/layout/base/nsPresContext.cpp#952

Differential Revision: https://phabricator.services.mozilla.com/D43952

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Emilio Cobos Álvarez 2019-08-29 21:25:12 +00:00
parent 7d9a18e3e7
commit a98a4dc71b

View File

@ -25,6 +25,8 @@
zoomDocument(document, 2.0);
document.body.offsetTop; // getBounds doesn't flush layout on its own, looks like.
[x, y, width, height] = getBounds(textNode);
testOffsetAtPoint(hyperText, x + width / 2, y + height / 2,
COORDTYPE_SCREEN_RELATIVE,