Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-24 13:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1747941: Don't assert in CleanUp if we failed to get a WorkerRef r=smaug

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D135006
This commit is contained in:
Randell Jesup 2022-01-04 13:58:23 +00:00
parent 17025d2d80
commit a9a672ddeb
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dom/promise/Promise.cpp
View File

@ -698,7 +698,8 @@ already_AddRefed<PromiseWorkerProxy> PromiseWorkerProxy::Create(
if (NS_WARN_IF(!workerRef)) {
// Probably the worker is terminating. We cannot complete the operation
// and we have to release all the resources.
// and we have to release all the resources. CleanUp releases the extra
// ref, too
proxy->CleanUp();
return nullptr;
}
@ -787,8 +788,10 @@ void PromiseWorkerProxy::CleanUp() {
return;
}
MOZ_ASSERT(mWorkerRef);
mWorkerRef->Private()->AssertIsOnWorkerThread();
// We can be called if we failed to get a WorkerRef
if (mWorkerRef) {
mWorkerRef->Private()->AssertIsOnWorkerThread();
}
// Release the Promise and remove the PromiseWorkerProxy from the holders of
// the worker thread since the Promise has been resolved/rejected or the