Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-25 13:51:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 917593 - Don't assert for zero-length strings. r=Waldo

Browse Source
This commit is contained in:
Bobby Holley 2013-09-24 08:03:22 -07:00
parent 2313b873cb
commit aa9e479063
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mfbt/Endian.h
View File

@ -238,9 +238,9 @@ class EndianUtils
{
DebugOnly<const uint8_t*> byteDestPtr = static_cast<const uint8_t*>(dest);
DebugOnly<const uint8_t*> byteSrcPtr = static_cast<const uint8_t*>(src);
MOZ_ASSERT((byteDestPtr < byteSrcPtr &&
MOZ_ASSERT((byteDestPtr <= byteSrcPtr &&
byteDestPtr + count <= byteSrcPtr) ||
(byteSrcPtr < byteDestPtr &&
(byteSrcPtr <= byteDestPtr &&
byteSrcPtr + count <= byteDestPtr));
}

5
mfbt/tests/TestEndian.cpp
View File

@ -396,5 +396,10 @@ main()
TestBulkInPlaceNoSwap(uint64_values);
TestBulkInPlaceNoSwap(int64_values);
// Make sure we don't incorrectly cry overlap for zero-length buffers.
uint64_t scratch = 0xdeadbeef;
NativeEndian::copyAndSwapFromLittleEndian(&scratch, &scratch, 0);
MOZ_ASSERT(scratch == 0xdeadbeef);
return 0;
}