Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-08 19:04:45 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1321705 - Remove "network.standard-url.(escape|encode)-utf8". r=valentin.gosu

Browse Source 
MozReview-Commit-ID: D6fRD9ElrBd

--HG--
extra : rebase_source : 6414effcf9e68859781de004e06eedea378e92ca
This commit is contained in:
Masatoshi Kimura 2016-12-30 10:28:18 +09:00
parent c08a6438f1
commit ab2ce0d4b3
3 changed files with 2 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
modules/libpref/init/all.js
View File

@ -1851,14 +1851,6 @@ pref("network.dns.localDomains", "");
// Contols whether or not "localhost" should resolve when offline
pref("network.dns.offline-localhost", true);
// This preference controls whether or not URLs with UTF-8 characters are
// escaped. Set this preference to TRUE for strict RFC2396 conformance.
pref("network.standard-url.escape-utf8", true);
// This preference controls whether or not URLs are always encoded and sent as
// UTF-8.
pref("network.standard-url.encode-utf8", true);
// The maximum allowed length for a URL - 1MB default
pref("network.standard-url.max-length", 1048576);

25
netwerk/base/nsStandardURL.cpp
View File

@ -140,8 +140,6 @@ static NS_DEFINE_CID(kStandardURLCID, NS_STANDARDURL_CID);
nsIIDNService *nsStandardURL::gIDN = nullptr;
bool nsStandardURL::gInitialized = false;
bool nsStandardURL::gEscapeUTF8 = true;
bool nsStandardURL::gAlwaysEncodeInUTF8 = true;
char nsStandardURL::gHostLimitDigits[] = { '/', '\\', '?', '#', 0 };
//----------------------------------------------------------------------------
@ -158,8 +156,6 @@ char nsStandardURL::gHostLimitDigits[] = { '/', '\\', '?', '#', 0 };
// nsStandardURL::nsPrefObserver
//----------------------------------------------------------------------------
#define NS_NET_PREF_ESCAPEUTF8 "network.standard-url.escape-utf8"
#define NS_NET_PREF_ALWAYSENCODEINUTF8 "network.standard-url.encode-utf8"
#define NS_NET_PREF_ENABLE_RUST "network.standard-url.enable-rust"
NS_IMPL_ISUPPORTS(nsStandardURL::nsPrefObserver, nsIObserver)
@ -225,13 +221,10 @@ nsSegmentEncoder::EncodeSegmentCount(const char *str,
}
}
// escape per RFC2396 unless UTF-8 and allowed by preferences
int16_t escapeFlags = (gEscapeUTF8 || mEncoder) ? 0 : esc_OnlyASCII;
uint32_t initLen = result.Length();
// now perform any required escaping
if (NS_EscapeURL(str + pos, len, mask | escapeFlags, result)) {
if (NS_EscapeURL(str + pos, len, mask, result)) {
len = result.Length() - initLen;
appended = true;
}
@ -280,7 +273,7 @@ nsSegmentEncoder::InitUnicodeEncoder()
nsSegmentEncoder name(useUTF8 ? nullptr : mOriginCharset.get())
#define GET_SEGMENT_ENCODER(name) \
GET_SEGMENT_ENCODER_INTERNAL(name, gAlwaysEncodeInUTF8)
GET_SEGMENT_ENCODER_INTERNAL(name, true)
#define GET_QUERY_ENCODER(name) \
GET_SEGMENT_ENCODER_INTERNAL(name, false)
@ -372,8 +365,6 @@ nsStandardURL::InitGlobalObjects()
nsCOMPtr<nsIPrefBranch> prefBranch( do_GetService(NS_PREFSERVICE_CONTRACTID) );
if (prefBranch) {
nsCOMPtr<nsIObserver> obs( new nsPrefObserver() );
prefBranch->AddObserver(NS_NET_PREF_ESCAPEUTF8, obs.get(), false);
prefBranch->AddObserver(NS_NET_PREF_ALWAYSENCODEINUTF8, obs.get(), false);
#ifdef MOZ_RUST_URLPARSE
prefBranch->AddObserver(NS_NET_PREF_ENABLE_RUST, obs.get(), false);
#endif
@ -1185,18 +1176,6 @@ nsStandardURL::PrefsChanged(nsIPrefBranch *prefs, const char *pref)
#define PREF_CHANGED(p) ((pref == nullptr) || !strcmp(pref, p))
#define GOT_PREF(p, b) (NS_SUCCEEDED(prefs->GetBoolPref(p, &b)))
if (PREF_CHANGED(NS_NET_PREF_ESCAPEUTF8)) {
if (GOT_PREF(NS_NET_PREF_ESCAPEUTF8, val))
gEscapeUTF8 = val;
LOG(("escape UTF-8 %s\n", gEscapeUTF8 ? "enabled" : "disabled"));
}
if (PREF_CHANGED(NS_NET_PREF_ALWAYSENCODEINUTF8)) {
if (GOT_PREF(NS_NET_PREF_ALWAYSENCODEINUTF8, val))
gAlwaysEncodeInUTF8 = val;
LOG(("encode in UTF-8 %s\n", gAlwaysEncodeInUTF8 ? "enabled" : "disabled"));
}
#ifdef MOZ_RUST_URLPARSE
if (PREF_CHANGED(NS_NET_PREF_ENABLE_RUST)) {
if (GOT_PREF(NS_NET_PREF_ENABLE_RUST, val)) {

3
netwerk/base/nsStandardURL.h
View File

@ -302,9 +302,6 @@ private:
static nsIIDNService *gIDN;
static char gHostLimitDigits[];
static bool gInitialized;
static bool gEscapeUTF8;
static bool gAlwaysEncodeInUTF8;
static bool gEncodeQueryInUTF8;
public:
#ifdef DEBUG_DUMP_URLS_AT_SHUTDOWN