Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-28 15:23:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1569314 - Remove IsOptionDisabled check and add relevant test case. r=emilio

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D108005
This commit is contained in:
Loek 2021-03-14 01:07:31 +00:00
parent 8165271661
commit ab2f5aa66a
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dom/html/HTMLSelectElement.cpp
View File

@ -1495,10 +1495,6 @@ bool HTMLSelectElement::IsValueMissing() const {
continue;
}
if (IsOptionDisabled(option)) {
continue;
}
return false;
}

12
testing/web-platform/tests/html/semantics/forms/the-select-element/select-validity.html
View File

@ -92,4 +92,16 @@ test(function() {
select.appendChild(optgroup);
assert_true(select.checkValidity(), "If one option within an optgroup or not is selected, the select should be considered valid.");
}, "Validation on selects with multiple set");
test(function() {
var select = document.createElement('select');
select.required = true;
var option = document.createElement('option');
option.value = 'test';
option.disabled = true;
option.selected = true;
select.appendChild(option);
assert_true(select.checkValidity(), "When a required select has an option that is selected and disabled, the select should be considered valid.");
}, "Validation on selects with non-empty disabled option");
</script>