A better fix for Bug #242672 --> Help menu should conform to Apple Human Interface Guidelines

don't needlessly pre-process messenger.dtd
restore the help about menu item
This commit is contained in:
scott%scott-macgregor.org 2004-06-11 17:01:29 +00:00
parent c36edfc815
commit ab3838483b
3 changed files with 7 additions and 8 deletions

View File

@ -388,11 +388,9 @@
<key id="key_mail" key="&messengerCmd.commandkey;" oncommand="toMessengerWindow();" modifiers="accel"/>
<key id="key_addressbook" key="&addressBookCmd.commandkey;" oncommand="toAddressBook();" modifiers="accel"/>
#ifdef XP_MACOSX
<!-- Mac Window keys -->
<key id="key_minimizeWindow" command="minimizeWindow" key="&minimizeWindow.key;" modifiers="accel"/>
<key id="key_macHelp" key="&hintsAndTips.commandkey;" oncommand="loadThrobberUrl('mailnews.hints_and_tips.url');" modifiers="accel"/>
<key id="key_macHelp" key="&hintsAndTipsMac.commandkey;" oncommand="loadThrobberUrl('mailnews.hints_and_tips.url');" modifiers="accel"/>
#endif
</keyset>
@ -1630,6 +1628,10 @@
<menupopup id="menu_HelpPopup">
<menuitem id="hintsAndTips" label="&hintsAndTips.label;" key="key_macHelp" oncommand="loadThrobberUrl('mailnews.hints_and_tips.url');"/>
<menuitem id="releaseNotes" accesskey="&releaseCmd.accesskey;" label="&releaseCmd.label;" oncommand="loadThrobberUrl('mailnews.release_notes.url');"/>
<menuseparator id="menu_HelpAboutSeparator"/>
<menuitem id="aboutName" accesskey="&aboutCmd.accesskey;"
label="&aboutCmd.label;"
oncommand="window.openDialog('chrome://messenger/content/aboutDialog.xul', 'About', 'modal,centerscreen,chrome,resizable=no');"/>
</menupopup>
</menu>
#else

View File

@ -56,7 +56,7 @@ en-US.jar:
locale/en-US/messenger/aboutDialog.dtd (locale/aboutDialog.dtd)
+ locale/en-US/messenger/junkMail.dtd (locale/junkMail.dtd)
+ locale/en-US/messenger/mailOverlay.dtd (locale/mailOverlay.dtd)
* locale/en-US/messenger/messenger.dtd (locale/messenger.dtd)
locale/en-US/messenger/messenger.dtd (locale/messenger.dtd)
+ locale/en-US/messenger/mailTasksOverlay.dtd (locale/mailTasksOverlay.dtd)
+ locale/en-US/messenger/msgAccountCentral.dtd (locale/msgAccountCentral.dtd)
+ locale/en-US/messenger/SearchDialog.dtd (locale/SearchDialog.dtd)

View File

@ -400,11 +400,8 @@
<!ENTITY releaseCmd.label "Release Notes">
<!ENTITY releaseCmd.accesskey "R">
<!ENTITY hintsAndTips.label "&brandFullName; Help">
#ifdef XP_MACOSX
<!ENTITY hintsAndTips.commandkey "?">
#else
<!ENTITY hintsAndTipsMac.commandkey "?">
<!ENTITY hintsAndTips.accesskey "h">
#endif
<!ENTITY aboutCmd.label "About &brandFullName;">
<!ENTITY aboutCmd.accesskey "A">