Bug 556656 - Blank form helper pops-up for un-populated menulists [r=mfinkle]

This commit is contained in:
Vivien Nicolas 2010-04-12 10:44:15 -04:00
parent 8ff1c68796
commit ab3a149abf
4 changed files with 24 additions and 4 deletions

View File

@ -1321,7 +1321,7 @@ var FormHelper = {
let currentIsSelect = this._isValidSelectElement(aNewElement);
if (currentIsSelect && !previousIsSelect) {
this._selectContainer.height = window.innerHeight / 1.8;
this._selectContainer.style.maxHeight = (window.innerHeight / 1.8) + "px";
let rootNode = this._container;
rootNode.insertBefore(this._selectContainer, rootNode.lastChild);

View File

@ -464,12 +464,14 @@
<!-- options dialog for select form field -->
<vbox id="select-container" hidden="true" pack="center">
<vbox id="select-container-inner" class="dialog-dark">
<spacer flex="1000"/>
<vbox id="select-container-inner" class="dialog-dark" flex="1">
<scrollbox id="select-list" flex="1" orient="vertical"/>
<hbox id="select-buttons" pack="center">
<button id="select-buttons-done" class="button-dark" label="&formHelper.done;" oncommand="SelectHelper.close();"/>
</hbox>
</vbox>
<spacer flex="1000"/>
</vbox>
<!-- bookmark window -->

View File

@ -1016,7 +1016,15 @@ pageaction .pageaction-desc[value=""] {
-moz-border-radius-bottomright: 0;
-moz-border-radius-bottomleft: 0;
padding: 8px 4px 8px 4px;
-moz-box-flex: 1;
-moz-box-flex: 0;
}
#form-helper-container > #select-container > #select-container-inner > scrollbox {
min-height: 70px;
}
#form-helper-container > #select-container > spacer {
display: none;
}
#form-helper-container > #select-container > #select-container-inner,
@ -1093,6 +1101,7 @@ pageaction .pageaction-desc[value=""] {
#select-list {
border: 1px solid gray;
background-color: #fff;
}
#select-list > option {

View File

@ -694,7 +694,15 @@ pageaction .pageaction-desc[value=""] {
-moz-border-radius-bottomleft: 0;
padding: 0.75mm 0.25mm 0.75mm 0.25mm;
border-bottom: 0;
-moz-box-flex: 1;
-moz-box-flex: 0;
}
#form-helper-container > #select-container > #select-container-inner > scrollbox {
min-height: 64px;
}
#form-helper-container > #select-container > spacer {
display: none;
}
#form-helper-container > #select-container > #select-container-inner,
@ -771,6 +779,7 @@ pageaction .pageaction-desc[value=""] {
#select-list {
border: 0.1mm solid gray;
background-color: #fff;
}
#select-list > option {