Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-20 00:35:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1509256 - Fix application update preferences for backward compatibility in Marionette and geckodriver. r=ato,bytesized

Browse Source 
Because in Marionette the application updates cannot be turned off
via the preference "app.update.disabledForTesting" (see bug 1508726),
the preference "app.update.auto" has to be used for the time being
to control that by default no updates should be downloaded and
installed.

Even "app.update.disabledForTesting" doesn't work right now,
it might be good to leave it. It would help us in the future
so that we won't have to release new Marionette client and
geckodriver releases, if it gets supported in Firefox.

Note that this band-aid fix will only work for Firefox releases
from 57 to 64. For Firefox 65 and onwards the fix on
bug 1508726 will be needed.

Depends on D13059

Differential Revision: https://phabricator.services.mozilla.com/D13060

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Henrik Skupin 2018-11-28 22:10:40 +00:00
parent 271aa30b73
commit ab56f42848
3 changed files with 20 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
testing/geckodriver/src/prefs.rs
View File

@ -21,7 +21,15 @@ lazy_static! {
("app.update.checkInstallTime", Pref::new(false)),
// Disable automatically upgrading Firefox
("app.update.disabledForTesting", Pref::new(true)),
// Bug 1508726: "disabledForTesting" has no effect in Marionette yet.
// As such automatically downloading updates, and installing those
// needs to be prevented. Sadly "app.update.auto" will not be enough
// anymore, because Windows has changed in how it handles updates. But
// at least we can workaround the problem on other platforms.
//
// DISCLAIMER: Don't remove or change this line until bug 1508726 has
// been fixed.
("app.update.auto", Pref::new(false)),
// Enable the dump function, which sends messages to the system
// console

17
testing/marionette/client/marionette_driver/geckoinstance.py
View File

@ -495,12 +495,17 @@ class DesktopInstance(GeckoInstance):
desktop_prefs = {
# Disable Firefox old build background check
"app.update.checkInstallTime": False,
# Disable application updates
"app.update.disabledForTesting": True,
"security.turn_off_all_security_so_that_viruses_can_take_over_this_computer": True,
# app.update.enabled is being removed. Once Firefox 62 becomes stable,
# the line below can be removed as well.
"app.update.enabled": False,
# Disable automatically upgrading Firefox
# Bug 1508726: "disabledForTesting" has no effect in Marionette yet.
# As such automatically downloading updates, and installing those
# needs to be prevented. Sadly "app.update.auto" will not be enough
# anymore, because Windows has changed in how it handles updates. But
# at least we can workaround the problem on other platforms.
#
# DISCLAIMER: Don't remove or change this line until bug 1508726 has
# been fixed.
"app.update.auto": False,
# Don't show the content blocking introduction panel
# We use a larger number than the default 22 to have some buffer

8
testing/marionette/components/marionette.js
View File

@ -64,14 +64,6 @@ const RECOMMENDED_PREFS = new Map([
// Make sure Shield doesn't hit the network.
["app.normandy.api_url", ""],
// Disable automatically upgrading Firefox.
//
// This should also be set in the profile prior to starting Firefox,
// as it is picked up at runtime.
["app.update.checkInstallTime", false],
["app.update.disabledForTesting", true],
["security.turn_off_all_security_so_that_viruses_can_take_over_this_computer", true],
// Increase the APZ content response timeout in tests to 1 minute.
// This is to accommodate the fact that test environments tends to be
// slower than production environments (with the b2g emulator being