Backed out 4 changesets (bug 1596086) for reftest failures on reftest.list . CLOSED TREE

Backed out changeset 651a7556124b (bug 1596086)
Backed out changeset ab2e0e2a9048 (bug 1596086)
Backed out changeset 00ccdb940ea2 (bug 1596086)
Backed out changeset 57869dbf0a8b (bug 1596086)
This commit is contained in:
Narcis Beleuzu 2019-11-27 01:38:33 +02:00
parent dbc0ec279f
commit abfef73a2b
10 changed files with 28 additions and 19 deletions

View File

@ -166,22 +166,25 @@ impl From<LinearGradientKey> for LinearGradientTemplate {
// Fast path not supported on segmented (border-image) gradients.
item.nine_patch.is_none();
let mut prev_offset = None;
// Convert the stops to more convenient representation
// for the current gradient builder.
let mut prev_color = None;
let stops: Vec<GradientStop> = item.stops.iter().map(|stop| {
let color: ColorF = stop.color.into();
min_alpha = min_alpha.min(color.a);
// The fast path doesn't support hard color stops, yet.
// Since the length of the gradient is a fixed size (512 device pixels), if there
// is a hard stop you will see bilinear interpolation with this method, instead
// of an abrupt color change.
if prev_offset == Some(stop.offset) {
supports_caching = false;
if let Some(prev_color) = prev_color {
// The fast path doesn't support hard color stops, yet.
// Since the length of the gradient is a fixed size (512 device pixels), if there
// is a hard stop you will see bilinear interpolation with this method, instead
// of an abrupt color change.
if prev_color == color {
supports_caching = false;
}
}
prev_offset = Some(stop.offset);
prev_color = Some(color);
GradientStop {
offset: stop.offset,

Binary file not shown.

Before

Width:  |  Height:  |  Size: 3.9 KiB

View File

@ -1,8 +0,0 @@
---
root:
items:
- type: gradient
bounds: 50 50 200 200
start: 0 0
end: 0 100
stops: [0.0, blue, 0.5 , red, 0.5, green]

View File

@ -14,8 +14,6 @@ platform(linux,mac) fuzzy(1,35000) == linear-stops.yaml linear-stops-ref.png
== linear-clamp-1b.yaml linear-clamp-1-ref.yaml
== linear-clamp-2.yaml linear-clamp-2-ref.yaml
== linear-hard-stop.yaml linear-hard-stop-ref.png
# dithering requires us to fuzz here
fuzzy(1,20000) == linear.yaml linear-ref.yaml
fuzzy(1,20000) == linear-reverse.yaml linear-ref.yaml

View File

@ -4,7 +4,8 @@ fuzzy-if(!contentSameGfxBackendAsCanvas,0-2,0-88500) fuzzy-if(azureSkiaGL,0-2,0-
== linear-diagonal-2a.html linear-diagonal-2-ref.html
== linear-diagonal-3a.html linear-diagonal-3-ref.html
== linear-diagonal-4a.html linear-diagonal-4-ref.html
fuzzy-if(webrender, 0-1, 23000-43000) == linear-premul.html linear-premul-ref.html
== linear-premul.html linear-premul-ref.html
fuzzy(0-1,0-800000) == linear-flipped-1.html linear-flipped-1-ref.html
== linear-position-1a.html linear-position-1-ref.html
== linear-repeat-1a.html linear-repeat-1-ref.html

View File

@ -0,0 +1,3 @@
[background-image-none-gradient-repaint.html]
expected:
if webrender and (os == "win"): FAIL

View File

@ -0,0 +1,3 @@
[angle-units-001.html]
expected:
if (os == "win") and webrender: FAIL

View File

@ -0,0 +1,3 @@
[angle-units-002.html]
expected:
if (os == "win") and webrender: FAIL

View File

@ -0,0 +1,3 @@
[angle-units-003.html]
expected:
if (os == "win") and webrender: FAIL

View File

@ -0,0 +1,3 @@
[angle-units-005.html]
expected:
if (os == "win") and webrender: FAIL