Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-23 04:41:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1840574: Don't try to get the selection in HyperTextAccessible::GetSelectionDOMRanges if the initial tree hasn't been constructed yet. a=pascalc

Browse Source 
Original Revision: https://phabricator.services.mozilla.com/D199601

Differential Revision: https://phabricator.services.mozilla.com/D201222
This commit is contained in:
James Teh 2024-02-11 11:18:27 +00:00
parent b54321eac9
commit ac4e11ca8f
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
accessible/generic/HyperTextAccessible.cpp
View File

@ -776,6 +776,17 @@ LayoutDeviceIntRect HyperTextAccessible::GetCaretRect(nsIWidget** aWidget) {
void HyperTextAccessible::GetSelectionDOMRanges(SelectionType aSelectionType,
nsTArray<nsRange*>* aRanges) {
if (IsDoc() && !AsDoc()->HasLoadState(DocAccessible::eTreeConstructed)) {
// Rarely, a client query can be handled after a DocAccessible is created
// but before the initial tree is constructed, since DoInitialUpdate happens
// during a refresh tick. In that case, there might be a DOM selection, but
// we can't use it. We will crash if we try due to mContent being null, etc.
// This should only happen in the parent process because we should never
// try to push the cache in a content process before the initial tree is
// constructed.
MOZ_ASSERT(XRE_IsParentProcess(), "Query before DoInitialUpdate");
return;
}
// Ignore selection if it is not visible.
RefPtr<nsFrameSelection> frameSelection = FrameSelection();
if (!frameSelection || frameSelection->GetDisplaySelection() <=

2
accessible/generic/LocalAccessible.h
View File

@ -928,7 +928,7 @@ class LocalAccessible : public nsISupports, public Accessible {
// Data Members
// mContent can be null in a DocAccessible if the document has no body or
// root element.
// root element, or if the initial tree hasn't been constructed yet.
nsCOMPtr<nsIContent> mContent;
RefPtr<DocAccessible> mDoc;