Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-11-27 06:43:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1806434: try removing fallback from scriptworker helper to see if it's actually needed r=taskgraph-reviewers,ahal

Browse Source 
While debugging https://bugzilla.mozilla.org/show_bug.cgi?id=1805989 I noticed this seemingly unnecessary fallback branch in one of the scriptworker helpers. It appears to me that we can drop the second and third branches there, and let everything not in the first branch get handled by get_signing_cert_scope instead.

That function ultimately has its own fallback for things without explicit matches, which applies the same default as the current third branch.

I ran this through tgdiff on try, which found no changes to any tasks for any set of parameters

Differential Revision: https://phabricator.services.mozilla.com/D165022
This commit is contained in:
Ben Hearsum 2022-12-19 15:34:21 +00:00
parent 6952f8568d
commit ae3459b394
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
taskcluster/gecko_taskgraph/util/scriptworker.py
View File

@ -364,10 +364,8 @@ def get_release_config(config):
def get_signing_cert_scope_per_platform(build_platform, is_shippable, config):
if "devedition" in build_platform:
return get_devedition_signing_cert_scope(config)
elif is_shippable:
return get_signing_cert_scope(config)
else:
return add_scope_prefix(config, "signing:cert:dep-signing")
return get_signing_cert_scope(config)
# generate_beetmover_upstream_artifacts {{{1