Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2025-04-04 21:52:44 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Convert InsertData calls into AppendData calls (which require less

Browse Source 
reflow/painting to handle) when the data is inserted at the end.  Bug 300797,
r=sicking, sr=roc, a=bsmedberg
This commit is contained in:
bzbarsky%mit.edu 2005-07-19 20:52:12 +00:00
parent 2ecae9f664
commit ae5c6e2f82
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
content/base/src/nsGenericDOMDataNode.cpp
View File

@ -396,7 +396,6 @@ nsGenericDOMDataNode::SubstringData(PRUint32 aStart, PRUint32 aCount,
nsresult nsresult
nsGenericDOMDataNode::AppendData(const nsAString& aData) nsGenericDOMDataNode::AppendData(const nsAString& aData)
{ {
#if 1
PRInt32 length = 0; PRInt32 length = 0;
// See bugzilla bug 77585. // See bugzilla bug 77585.
@ -426,9 +425,6 @@ nsGenericDOMDataNode::AppendData(const nsAString& aData)
} }
return NS_OK; return NS_OK;
#else
return ReplaceData(mText.GetLength(), 0, aData);
#endif
} }
nsresult nsresult
@ -455,6 +451,15 @@ nsGenericDOMDataNode::ReplaceData(PRUint32 aOffset, PRUint32 aCount,
return NS_ERROR_DOM_INDEX_SIZE_ERR; return NS_ERROR_DOM_INDEX_SIZE_ERR;
} }
// Fast path (hit by editor when typing at the end of the paragraph, for
// example): aOffset == textLength (so just doing an append; note that in
// this case any value of aCount would just get converted to 0 by the very
// next if block). Call AppendData so that we pass PR_TRUE for our aAppend
// arg to CharacterDataChanged.
if (aOffset == textLength) {
return AppendData(aData);
}
// Allocate new buffer // Allocate new buffer
PRUint32 endOffset = aOffset + aCount; PRUint32 endOffset = aOffset + aCount;
if (endOffset > textLength) { if (endOffset > textLength) {