Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-07 09:54:42 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Bug 1359453 - Use standard exception for selection.removeRange() r=masayuki

Browse Source 
The test change is already upstream:
https://github.com/w3c/web-platform-tests/pull/5686

The spec change has not officially been accepted yet as of this writing,
possibly delayed for IPR review:
https://github.com/w3c/selection-api/pull/87

MozReview-Commit-ID: 3auwvwP4X72

--HG--
extra : rebase_source : 0396cd7c454b234598d77427bc20c6ea0645dc2e
This commit is contained in:
Aryeh Gregor 2017-04-26 15:50:36 +03:00
parent 966c8d03f5
commit aec49bff0f
3 changed files with 4 additions and 88 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
layout/generic/nsSelection.cpp
View File

@ -4076,7 +4076,7 @@ Selection::RemoveItem(nsRange* aItem)
}
}
if (idx < 0)
return NS_ERROR_INVALID_ARG;
return NS_ERROR_DOM_NOT_FOUND_ERR;
mRanges.RemoveElementAt(idx);
aItem->SetSelection(nullptr);

86
testing/web-platform/meta/selection/removeRange.html.ini
View File

@ -1,86 +0,0 @@
[removeRange.html]
type: testharness
[removeRange() with Range 0]
expected: FAIL
[removeRange() with Range 1]
expected: FAIL
[removeRange() with Range 2]
expected: FAIL
[removeRange() with Range 3]
expected: FAIL
[removeRange() with Range 4]
expected: FAIL
[removeRange() with Range 5]
expected: FAIL
[removeRange() with Range 6]
expected: FAIL
[removeRange() with Range 7]
expected: FAIL
[removeRange() with Range 14]
expected: FAIL
[removeRange() with Range 15]
expected: FAIL
[removeRange() with Range 16]
expected: FAIL
[removeRange() with Range 17]
expected: FAIL
[removeRange() with Range 18]
expected: FAIL
[removeRange() with Range 22]
expected: FAIL
[removeRange() with Range 23]
expected: FAIL
[removeRange() with Range 26]
expected: FAIL
[removeRange() with Range 27]
expected: FAIL
[removeRange() with Range 28]
expected: FAIL
[removeRange() with Range 29]
expected: FAIL
[removeRange() with Range 30]
expected: FAIL
[removeRange() with Range 31]
expected: FAIL
[removeRange() with Range 32]
expected: FAIL
[removeRange() with Range 34]
expected: FAIL
[removeRange() with Range 35]
expected: FAIL
[removeRange() with Range 36]
expected: FAIL
[removeRange() with Range 37]
expected: FAIL
[removeRange() with Range 38]
expected: FAIL
[removeRange() with Range 39]
expected: FAIL

4
testing/web-platform/tests/selection/removeRange.html
View File

@ -30,7 +30,9 @@ testRanges.forEach(function(rangeData, index) {
var equivalentRange = ownerDocument(endpoints[0]).createRange();
equivalentRange.setStart(endpoints[0], endpoints[1]);
equivalentRange.setEnd(endpoints[2], endpoints[3]);
selection.removeRange(equivalentRange);
assert_throws("NotFoundError",
function() { selection.removeRange(equivalentRange) },
"Removing a different range should throw");
assert_equals(selection.rangeCount, 1, 'Equivalent Range should not remove the registered Range.');
}, 'removeRange() with Range ' + index);